Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import-scripts: fix boolean rendering #246

Merged
merged 1 commit into from Dec 7, 2020
Merged

import-scripts: fix boolean rendering #246

merged 1 commit into from Dec 7, 2020

Conversation

ncfavier
Copy link
Member

@ncfavier ncfavier commented Dec 6, 2020

Apparently isinstance(True, int) is True in Python, and so booleans are rendered as Python values, with a capital letter. I changed the conditions to test against type(value) instead.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2020

Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@garbas garbas merged commit ba3fe60 into master Dec 7, 2020
@garbas garbas deleted the ncfavier-patch-1 branch December 7, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants