Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.clickhouse-driver: init at 0.1.5 #106039

Merged
merged 2 commits into from Dec 6, 2020
Merged

pythonPackages.clickhouse-driver: init at 0.1.5 #106039

merged 2 commits into from Dec 6, 2020

Conversation

breakds
Copy link
Contributor

@breakds breakds commented Dec 6, 2020 •
edited

Motivation for this change

There is already clickhouse packaged in nixpkgs, and it would more convenient for the big data developers if the various clients are there as well. This pull request packages clickhouse-driver, which enables python developers to interact with a clickhouse server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 changed the title pythonPacakges.clickhouse-driver: init at 0.1.5 pythonPackages.clickhouse-driver: init at 0.1.5 Dec 6, 2020
@SuperSandro2000
Copy link
Member

Please put each package into its own commit with the message like pythonPackages.clickhouse-driver: init at 0.1.5.

@breakds breakds force-pushed the clickhouse-driver branch 2 times, most recently from 7cda52a to 18ec4ff Compare December 6, 2020 05:27
@breakds
Copy link
Contributor Author

breakds commented Dec 6, 2020

Please put each package into its own commit with the message like pythonPackages.clickhouse-driver: init at 0.1.5.

Split the original commit into two for each packages. Thanks for prompt review!

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 106039 run on x86_64-linux 1

6 packages built:
  • python37Packages.clickhouse-cityhash
  • python37Packages.clickhouse-driver
  • python38Packages.clickhouse-cityhash
  • python38Packages.clickhouse-driver
  • python39Packages.clickhouse-cityhash
  • python39Packages.clickhouse-driver

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106039 run on x86_64-linux 1

6 packages built:
  • python37Packages.clickhouse-cityhash
  • python37Packages.clickhouse-driver
  • python38Packages.clickhouse-cityhash
  • python38Packages.clickhouse-driver
  • python39Packages.clickhouse-cityhash
  • python39Packages.clickhouse-driver

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106039 run on x86_64-darwin 1

6 packages built:
  • python37Packages.clickhouse-cityhash
  • python37Packages.clickhouse-driver
  • python38Packages.clickhouse-cityhash
  • python38Packages.clickhouse-driver
  • python39Packages.clickhouse-cityhash
  • python39Packages.clickhouse-driver

@SuperSandro2000 SuperSandro2000 merged commit 5b7667a into NixOS:master Dec 6, 2020
@breakds breakds deleted the clickhouse-driver branch December 6, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@breakds @SuperSandro2000 @RaghavSood