Result of nixpkgs-review pr 106042 run on x86_64-linux 1

Result of nixpkgs-review pr 106042 run on x86_64-linux 1

1 package built:

Does this suggest any issue found in nixpkgs-review? I ran the command locally and didn't see issues.

Does this suggest any issue found in nixpkgs-review? I ran the command locally and didn't see issues.

Nope, this just means that the review tool was able to build the package successfully

nixpkgs-review is more useful when testing existing packages that are used by other packages in the tree and helping make sure they still compile - since this is a new addition, we only get a single built package, which can then be inspected (via the result symlink)

In this case, I used it to just easily pull your changes, apply them to the master branch, build the package, and then check that the include and lib folders contain the expected header and cmake files.

The command in the issue template (nix-shell -p nixpkgs-review --run "nixpkgs-review wip") only works with WIP changes - once you have opened the PR, you can use nixpkgs-review pr 106042 to build the package and any downstream packages locally, and add nixpkgs-review pr --post-result 106042 if you want to build and automatically post the results as a comment (requires a github token configured)

Does this suggest any issue found in nixpkgs-review? I ran the command locally and didn't see issues.

Nope, this just means that the review tool was able to build the package successfully

nixpkgs-review is more useful when testing existing packages that are used by other packages in the tree and helping make sure they still compile - since this is a new addition, we only get a single built package, which can then be inspected (via the result symlink)

In this case, I used it to just easily pull your changes, apply them to the master branch, build the package, and then check that the include and lib folders contain the expected header and cmake files.

The command in the issue template (nix-shell -p nixpkgs-review --run "nixpkgs-review wip") only works with WIP changes - once you have opened the PR, you can use nixpkgs-review pr 106042 to build the package and any downstream packages locally, and add nixpkgs-review pr --post-result 106042 if you want to build and automatically post the results as a comment (requires a github token configured)

Thanks a lot for the detailed explanation and prompt answer. I'll take a note and add such a comment explaining what have been built next time.

Appreciate the help!