Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.no-title-bar: 9 -> 11, unbreak #106828

Merged
merged 2 commits into from Feb 25, 2021
Merged

gnomeExtensions.no-title-bar: 9 -> 11, unbreak #106828

merged 2 commits into from Feb 25, 2021

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Dec 13, 2020

Motivation for this change

Second attempt at #88679, since upstream tagged a release. I've been running this on my system for a while, it all works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amaxine
gnomeExtensions.no-title-bar: unbreak
32b7d76 
9 -> 2020-05-14
Switches to a supported fork, updates patches as necessary
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Dec 13, 2020
@ofborg ofborg bot requested a review from jonafato December 13, 2020 14:25
drewrisinger
drewrisinger suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM minus minor comment
  • Commits should probably be squashed
  • Builds fine via nix-review on x86_64-linux. No further testing done (now sure how, on headless machine).
https://github.com/NixOS/nixpkgs/pull/106828
1 package built:
gnomeExtensions.no-title-bar

pkgs/desktops/gnome-3/extensions/no-title-bar/default.nix Outdated Show resolved Hide resolved
drewrisinger
drewrisinger approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
  • No further testing done by me
https://github.com/NixOS/nixpkgs/pull/106828
1 package built:
gnomeExtensions.no-title-bar

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106828 run on x86_64-linux 1

1 package built:
  • gnomeExtensions.no-title-bar

@amaxine
Copy link
Contributor Author

amaxine commented Feb 24, 2021

Is there anything I can do to get this merged? Would like to see this in master before 21.05 and there's another release of this extension 😅

@buckley310
Copy link
Contributor

buckley310 commented Feb 25, 2021 •
edited

LGTM
I'm currently testing with this patch applied to unstable. Works just fine. I may end up keeping it :)

@SuperSandro2000 SuperSandro2000 merged commit 995d98c into NixOS:master Feb 25, 2021
@amaxine amaxine deleted the no-title-bar_unbreak branch July 19, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@jonafato jonafato Awaiting requested review from jonafato

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amaxine @SuperSandro2000 @buckley310 @drewrisinger