Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standardnotes 3.5.11 #106521

Closed
wants to merge 2 commits into from
Closed

Fix standardnotes 3.5.11 #106521

wants to merge 2 commits into from

Conversation

tasmo
Copy link
Contributor

@tasmo tasmo commented Dec 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from M-Gregoire December 10, 2020 08:25
@svrana
Copy link
Member

svrana commented Jan 10, 2021

Be great to see this merged as standardnotes will not start without it.

@mveytsman
Copy link
Contributor

+1 on merging this: it's blocking standard notes from starting

@svrana svrana mentioned this pull request Jan 22, 2021
Merged
10 tasks
@taku0
Copy link
Contributor

taku0 commented Feb 13, 2021

Close in favor of #110531.

@taku0 taku0 closed this Feb 13, 2021
@tasmo tasmo deleted the fix-for-standardnotes-3.5.11 branch February 13, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Gregoire M-Gregoire Awaiting requested review from M-Gregoire

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tasmo @svrana @mveytsman @taku0 @SuperSandro2000