Convert Eclipse from Docbook to CommonMark #106532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Dec 10, 2020
| Eclipse Platform with the popular Eclipse Color Theme plugin and also | ||
| allow Eclipse to use more RAM. You could then add | ||
|
|
||
| ```ShellSession |
There was a problem hiding this comment.
Sorry. I am no markdown specialist.
Should I replace ShellSession by nix?
There was a problem hiding this comment.
Yes. And same for the other Nix code.
| are available for installation using `eclipseWithPlugins` by running | ||
|
|
||
| ```ShellSession | ||
| $ nix-env -f '<nixpkgs>' -qaP -A eclipses.plugins --description |
There was a problem hiding this comment.
This should not be indented.
|
What do I have to do to get this pull request merged? |
|
The review points still have not been resolved. |
ngiger
force-pushed
the
eclipse-doc
branch
2 times, most recently
from
7e0ddcf
to
ebe1ea7
Compare
|
Please run the following command to run |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Converted xml docs to md docs as per issue #105251
Things done
Converted xml to md and updated index.xml to reference it.