nerdctl: init at 0.2.0 #106546
nerdctl: init at 0.2.0 #106546
Conversation
|
Result of 2 packages built:
|
Both get |
| "-w" | ||
| "-s" | ||
| "-X github.com/AkihiroSuda/nerdctl/pkg/version.Version=v${version}" | ||
| "-X github.com/AkihiroSuda/nerdctl/pkg/version.Revision=${commitSha}" |
There was a problem hiding this comment.
A commit hash that hasn't been updated in a version bump often gets overlooked in reviews, the bot won't update it and if the revision is overridden it will be incorrect unless it is also updated to match. I'd suggest just using src.rev.
| "-X github.com/AkihiroSuda/nerdctl/pkg/version.Revision=${commitSha}" | |
| "-X github.com/AkihiroSuda/nerdctl/pkg/version.Revision=${src.rev}" |
There was a problem hiding this comment.
I've tried it before but it's just the same value as ${version}
There was a problem hiding this comment.
Yes, that's correct. Currently there isn't an easy way to get the git hash without setting it manually which then gets overlooked.
There was a problem hiding this comment.
👍 I'm happy to leave it empty so it falls back to it's default value (<unknown>) but I can put src.rev if you'd prefer
There was a problem hiding this comment.
src.rev is useful if the revision is overridden to point to another commit.
There was a problem hiding this comment.
Ok. I'm now specifically setting it to it's default of <unknown>
|
So if I understand correctly the binary itself during normal use doesn't require it but it's the module which starts the daemon that then points to the cni-plugins dir? In this case with |
|
Result of 2 packages built:
|
Neither will work at all without the module or the user doing manual setup. Besides |
Motivation for this change
Package
nerdctlThere is
nerdctl-unwrappedwhich is as-is, andnerdctlwhich is wrapped withcni-pluginsandbuildkitto allow for networking and building containers.Since there is
nerdctlandnerdctl-unwrappedlet me know if I need to change my commit message to fit contributinghttps://github.com/AkihiroSuda/nerdctl#install
I'm not sure why
podmanandcri-ocan get away withcni-pluginsjust being arguments & not even in the PATH.https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/virtualization/podman/wrapper.nix#L13
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/virtualization/cri-o/wrapper.nix#L11
@adisbladis @zowoq
nerdctlwill explicitly look for severalcni-pluginsbinaries in/opt/cni/binwhich is overridden with the env varCNI_PATHin the wrapped version.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)