Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox wrapper preserve addon settings #105985

Closed
wants to merge 1 commit into from
Closed

Firefox wrapper preserve addon settings #105985

wants to merge 1 commit into from

Conversation

Qubasa
Copy link
Contributor

@Qubasa Qubasa commented Dec 5, 2020 •
edited

Motivation for this change

In the current firefox wrapper every addon update discards the addon settings, like mentioned here #105783 (comment).

Things done

This change makes the extid static and user defined. However now it has to be made sure that every addon gets assigned an unique name by the user. I do not know how to do that in the nix language so if someone knows how please comment how ^^.

I would like to do something like this:
1607180523_grim

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Qubasa Qubasa force-pushed the firefoxWrapperAddonSettings branch from bade69f to 0c68118 Compare December 5, 2020 15:04
@Qubasa Qubasa mentioned this pull request Dec 5, 2020
Open
@Qubasa Qubasa force-pushed the firefoxWrapperAddonSettings branch from 0c68118 to 16c0e42 Compare December 5, 2020 17:13
@Qubasa Qubasa closed this Dec 5, 2020
@beardhatcode
Copy link
Contributor

Yes, this is what I had in mind. However, i do not really like the 12345@, in the implementaion I currently use I add an attr to fetchFirefoxAddon that allows me to specify the extid myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt mweinelt will be requested when the pull request is marked ready for review mweinelt is a code owner

Assignees
No one assigned
Labels
6.topic: fetch 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Qubasa @beardhatcode