Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add staging workflow diagram #105986

Merged
merged 2 commits into from Dec 9, 2020
Merged

doc: Add staging workflow diagram #105986

merged 2 commits into from Dec 9, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 5, 2020

Motivation for this change

Add diagram describing the staging workflow to Submitting changes docs. Depends on #105962

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 5, 2020

Rendered:

image

@jtojnar jtojnar mentioned this pull request Dec 5, 2020
Merged
@Ericson2314
Copy link
Member

The number of technologies that go into the this final quite remarkable :D.

@jtojnar jtojnar marked this pull request as ready for review December 8, 2020 07:57
@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 8, 2020

Rebased onto master and checked that the image displays in epub too (using mupdf).

@jtojnar jtojnar requested a review from ryantm December 8, 2020 08:08
@ryantm
Copy link
Member

ryantm commented Dec 9, 2020

Result of nixpkgs-review pr 105986 1

1 package built:
  • pandoc-lua-filters

@jtojnar
Copy link
Contributor Author

jtojnar commented Dec 9, 2020

Changed pandoc-lua-filters platform to all.

ryantm
ryantm approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and rendering look good to me.

@ryantm ryantm merged commit bc7013c into NixOS:master Dec 9, 2020
@jtojnar jtojnar deleted the staging-workflow-diagram branch December 9, 2020 16:09
@greizgh greizgh mentioned this pull request Jan 18, 2021
Merged
10 tasks
@jtojnar jtojnar mentioned this pull request Feb 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @Ericson2314 @ryantm