nixos/manual: small formatting improvements #105969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs on patch-7 [!]
❯ nix-build nixos/release.nix -A manual.x86_64-linux <<<
these derivations will be built:
/nix/store/xqmq3ajrdqycsnp8p5fzk39aw4lkwmjv-generated-docbook.drv
/nix/store/sjy1kb3lhfhij4hnyc6n24r5apdjlssz-nixos-manual-combined.drv
/nix/store/595ynw127rfaz4fvvijqh7rzlh10g43i-manual-olinkdb.drv
/nix/store/6r64y841xj1wgy0hpp29vf1hls96dg4r-nixos-manual-html.drv
building '/nix/store/xqmq3ajrdqycsnp8p5fzk39aw4lkwmjv-generated-docbook.drv'...
building '/nix/store/sjy1kb3lhfhij4hnyc6n24r5apdjlssz-nixos-manual-combined.drv'...
manual-combined.xml validates
man-pages-combined.xml validates
building '/nix/store/595ynw127rfaz4fvvijqh7rzlh10g43i-manual-olinkdb.drv'...
Writing /nix/store/l49yx34lzqxvjw6fd69vrbsi880zg056-manual-olinkdb/manual.db for book(book-nixos-manual)
building '/nix/store/6r64y841xj1wgy0hpp29vf1hls96dg4r-nixos-manual-html.drv'...
Writing options.html for appendix(ch-options)
Writing release-notes.html for appendix(ch-release-notes)
Writing index.html for book(book-nixos-manual)
/nix/store/vil7fsfxizmfnkmbn9ximi7svk18zr9j-nixos-manual-html
nixpkgs on patch-7 took 36s
❯ |
ivankovnatsky
requested review from
nbp,
thoughtpolice and
WilliButz
as code owners
ivankovnatsky
force-pushed
the
patch-7
branch
from
141cfa8
to
87d8fc0
Compare
jtojnar
reviewed
Dec 6, 2020
| @@ -93,23 +94,23 @@ services.httpd.extraModules = [ | |||
| </para> | |||
| <para> | |||
| <screen> | |||
| <prompt>$ </prompt> svn create REPO_NAME | |||
There was a problem hiding this comment.
The spaces are supposed to be in prompt so that it is not copied.
There was a problem hiding this comment.
i think it won't let copy even now:
(correct me if i didn't understood you correctly)
but i would feel much help if i can copy any code formatted block for re-use.
There was a problem hiding this comment.
In the picture, you can see that the space before the command is selected. But the space is not a part of the command so it should not be copied.
To achieve that, the space needs to be inside the prompt:
<prompt>$ </prompt>fooo
instead of outside it like you have here:
<prompt>$</prompt> fooo
There was a problem hiding this comment.
got it, corrected.
ivankovnatsky
force-pushed
the
patch-7
branch
from
87d8fc0
to
4c812ea
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
mostly indentation fixes in ``` code blocks.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)