Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended mission in the analyser #2807

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Dec 3, 2020

This allows the analyser to try to see one full revolution if the mission_duration appears to be too short. This will be useful in the flight plan to figure out what orbit the vessel would be in if the orbit were not interrupted by the next manœuvre.

ksp_plugin/orbit_analyser.hpp Show resolved Hide resolved
@@ -89,6 +89,9 @@ class OrbitAnalyser {
Instant first_time;
DegreesOfFreedom<Barycentric> first_degrees_of_freedom;
Time mission_duration;
// The analyser may compute the trajectory up to |extended_mission_duration|
// to ensure that at least one revolution is analysed.
std::optional<Time> extended_mission_duration;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a place that sets this parameter. What am I missing?

Sorry, something went wrong.

Copy link
Member Author

@eggrobin eggrobin Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is currently unused.

It will be used by flight plan analysis.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Dec 5, 2020
@eggrobin eggrobin merged commit cb74501 into mockingbirdnest:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants