Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.py-air-control-exporter: init at 0.1.4 #105966

Merged
merged 1 commit into from Dec 6, 2020
Merged

python3Packages.py-air-control-exporter: init at 0.1.4 #105966

merged 1 commit into from Dec 6, 2020

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Dec 5, 2020 •
edited

Motivation for this change

py-air-control-exporter is not yet packaged in nixpkgs.

This is a new leaf package. It's size is:

nix path-info -sh  $(nix-build --no-out-link -A pkgs.python3Packages.py-air-control-exporter)
/nix/store/7sa2yddlhf10y33k53a4zs19vnplclw9-python3.8-py-air-control-exporter-0.1.4       15.9K
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @SuperSandro2000 @lukegb

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105966 run on x86_64-darwin 1

3 packages built:
  • python37Packages.py-air-control-exporter
  • python38Packages.py-air-control-exporter
  • python39Packages.py-air-control-exporter

@lukegb
Copy link
Contributor

lukegb commented Dec 5, 2020

If this is a Prometheus exporter, please add a NixOS module for it.

@urbas
Copy link
Contributor Author

urbas commented Dec 5, 2020

If this is a Prometheus exporter, please add a NixOS module for it.

Good point! Would it be okay if I add it in a separate pull request?

@lukegb
Copy link
Contributor

lukegb commented Dec 5, 2020

If this is a Prometheus exporter, please add a NixOS module for it.

Good point! Would it be okay if I add it in a separate pull request?

Sure :)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105966 run on x86_64-linux 1

3 packages built:
  • python37Packages.py-air-control-exporter
  • python38Packages.py-air-control-exporter
  • python39Packages.py-air-control-exporter

@SuperSandro2000 SuperSandro2000 merged commit 308cdda into NixOS:master Dec 6, 2020
@urbas urbas deleted the py-air-control-exporter branch December 6, 2020 10:40
@urbas urbas mentioned this pull request Dec 6, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urbas @SuperSandro2000 @lukegb