Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.118.4 -> 0.118.5 #105981

Merged
merged 2 commits into from Dec 5, 2020
Merged

home-assistant: 0.118.4 -> 0.118.5 #105981

merged 2 commits into from Dec 5, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 5, 2020

Motivation for this change

New upstream release.

https://github.com/home-assistant/core/releases/tag/0.118.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

delroth
delroth approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for pyatmo.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105981 run on x86_64-linux 1

1 package failed to build:
  • python39Packages.pyatmo
3 packages built:
  • home-assistant
  • python37Packages.pyatmo
  • python38Packages.pyatmo

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 5, 2020 •
edited

Result of nixpkgs-review pr 105981 1

2 packages failed to build:
  • home-assistant
  • python39Packages.pyatmo
2 packages built:
  • python37Packages.pyatmo
  • python38Packages.pyatmo
Tests running...
======================================================================
ERROR: fixtures.tests._fixtures.test_monkeypatch.TestMonkeyPatch.test_patch_classmethod_with_boundmethod
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-python3.9-fixtures-3.0.0.drv-0/fixtures-3.0.0/fixtures/tests/_fixtures/test_monkeypatch.py", line 223, in test_patch_classmethod_with_boundmethod
    slf, cls = C.foo_cls()
TypeError: bar_two_args() missing 1 required positional argument: 'arg'
======================================================================
ERROR: fixtures.tests._fixtures.test_monkeypatch.TestMonkeyPatch.test_patch_classmethod_with_classmethod
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-python3.9-fixtures-3.0.0.drv-0/fixtures-3.0.0/fixtures/tests/_fixtures/test_monkeypatch.py", line 191, in test_patch_classmethod_with_classmethod
    cls, target_class = C.foo_cls()
ValueError: not enough values to unpack (expected 2, got 1)

Ran 128 tests in 2.087s

@mweinelt
Copy link
Member Author

mweinelt commented Dec 5, 2020

testing-cabal/fixtures#44

@mweinelt mweinelt merged commit 0dae0a2 into NixOS:master Dec 5, 2020
@mweinelt mweinelt deleted the home-assistant branch December 5, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@globin globin Awaiting requested review from globin

@Mic92 Mic92 Awaiting requested review from Mic92

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @delroth