Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: convert Submitting changes to Markdown #105962

Merged
merged 3 commits into from Dec 8, 2020
Merged

doc: convert Submitting changes to Markdown #105962

merged 3 commits into from Dec 8, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 5, 2020 •
edited

Motivation for this change

Closes: #105960

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Viewed the manual in the browser
  • Checked HTML diff
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ryantm

@jtojnar jtojnar mentioned this pull request Dec 5, 2020
Merged
10 tasks
ryantm
ryantm approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code, diff, rendering all look good. Thanks!

@ryantm ryantm merged commit c2effbb into NixOS:master Dec 8, 2020
@jtojnar jtojnar deleted the db-submitting-changes branch December 8, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Submitting Changes from DocBook to CommonMark
2 participants
@jtojnar @ryantm