Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zigbee2mqtt: 1.16.1 -> 1.16.2 #105973

Merged
merged 1 commit into from Dec 5, 2020
Merged

zigbee2mqtt: 1.16.1 -> 1.16.2 #105973

merged 1 commit into from Dec 5, 2020

Conversation

zaninime
Copy link
Contributor

@zaninime zaninime commented Dec 5, 2020

Motivation for this change

https://github.com/Koenkk/zigbee2mqtt/releases/tag/1.16.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @mweinelt @sweber83

mweinelt
mweinelt reviewed Dec 5, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch regarding the DATADIR. I have a question and a suggestion.

pkgs/servers/zigbee2mqtt/update.sh Outdated Show resolved Hide resolved
pkgs/servers/zigbee2mqtt/default.nix Outdated Show resolved Hide resolved
@mweinelt
Copy link
Member

mweinelt commented Dec 5, 2020

@GrahamcOfBorg test zigbee2mqtt

@ofborg ofborg bot requested a review from sweber83 December 5, 2020 13:44
@mweinelt mweinelt requested a review from makefu December 5, 2020 13:47
makefu
makefu reviewed Dec 5, 2020
View reviewed changes
pkgs/servers/zigbee2mqtt/default.nix Outdated
mkdir $out/bin
ln -s $out/lib/node_modules/zigbee2mqtt/index.js $out/bin/zigbee2mqtt
ln -s $out/lib/node_modules/zigbee2mqtt/cli.js $out/bin/zigbee2mqtt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to use upstream generated binary? that way the chmod, rm,mkdir and ln commands would be come obsolete.
or is upstream bin/zigbee2mqtt symlink not working afterwards?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/binary/executable/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I removed the postInstall completely and the NixOS test is running just fine.

@zaninime
Copy link
Contributor Author

zaninime commented Dec 5, 2020 •
edited

Btw: I actually tweaked the update.sh script locally to run a git checkout node.nix after node2nix is invoked, as it was generating an invalid node.nix. The newly generated one was passing utillinux instead of util-linux to a downstream derivation.

@mweinelt
Copy link
Member

mweinelt commented Dec 5, 2020

Btw: I actually tweaked the update.sh script locally to run a git checkout node.nix after node2nix is invoked, as it was generating an invalid node.nix. The newly generated one was passing utillinux instead of util-linux to a downstream derivation.

Yeah, that was the reason why I didn't update z2m to 1.16.2 already. Created an upstream issue over at svanderburg/node2nix#213.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105973 run on x86_64-linux 1

1 package built:
  • zigbee2mqtt

makefu
makefu approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@makefu makefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed this version of zigbee2mqtt on my server at home and the network got kept alive!

@mweinelt mweinelt merged commit f5f4a5d into NixOS:master Dec 5, 2020
@zaninime zaninime deleted the zigbee2mqtt branch July 30, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@makefu makefu makefu approved these changes

@sweber83 sweber83 Awaiting requested review from sweber83

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zaninime @mweinelt @SuperSandro2000 @makefu