Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pikepdf: 1.18.0 -> 2.2.0 #105977

Closed
wants to merge 3 commits into from
Closed

python.pkgs.pikepdf: 1.18.0 -> 2.2.0 #105977

wants to merge 3 commits into from

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Dec 5, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Dec 5, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from symphorien and Kiwi December 5, 2020 14:17
@symphorien
Copy link
Member

pdfarranger works.
Where does the qpdf dependency come from ? It is not mentioned in the release notes.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105977 run on x86_64-linux 1

8 packages built:
  • img2pdf (python38Packages.img2pdf)
  • ocrmypdf
  • pdfarranger
  • python37Packages.img2pdf
  • python37Packages.pikepdf
  • python38Packages.pikepdf
  • python39Packages.img2pdf
  • python39Packages.pikepdf

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104377 1

1 package failed to build:
  • directx-shader-compiler
installing
mv: missing destination file operand after '/nix/store/f2hdrvqkfz5hcksc5xacs0y4r7nfd2zf-directx-shader-compiler-1.5.2010/lib/'
Try 'mv --help' for more information.

@doronbehar
Copy link
Contributor Author

pdfarranger works.
Where does the qpdf dependency come from ? It is not mentioned in the release notes.

Somehow I got an error before that I can't reproduce anymore related to qpdf when I launched pdfarranger. I removed it now. Also the comment near the sed commands to pikepdf's setup.py now include a comment saying these should be removed when staging since wheel is updated in staging. Now when I think about it, perhaps I should push these updates to #105584 ?

@doronbehar
Copy link
Contributor Author

Now I see that even pikepdf is updated there, properly without those sed commands. I'm updating pdfarranger there and closing this.

@doronbehar doronbehar closed this Dec 6, 2020
@doronbehar doronbehar mentioned this pull request Dec 6, 2020
Merged
10 tasks
@doronbehar doronbehar deleted the pkg/python/pikepdf branch March 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@symphorien symphorien Awaiting requested review from symphorien

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @symphorien @SuperSandro2000