matomo: 3.14.1 -> 4.0.4 #105983
matomo: 3.14.1 -> 4.0.4 #105983
Conversation
nixpkgs-fmt
|
Perhaps the database update note should go into the release notes - won't save people on unstable, but I'm sure there's one or two people in the world who only use stable NixOS releases |
There was a problem hiding this comment.
As mentioned you should add release notes. I'd like to see @florianjacob approved this before we merge it if possible.
| (mkRenamedOptionModule [ | ||
| "services" | ||
| "piwik" | ||
| "enable" | ||
| ] [ | ||
| "services" | ||
| "matomo" | ||
| "enable" | ||
| ]) | ||
| (mkRenamedOptionModule [ | ||
| "services" | ||
| "piwik" | ||
| "webServerUser" | ||
| ] [ | ||
| "services" | ||
| "matomo" | ||
| "webServerUser" | ||
| ]) | ||
| (mkRemovedOptionModule [ | ||
| "services" | ||
| "piwik" | ||
| "phpfpmProcessManagerConfig" | ||
| ] | ||
| "Use services.phpfpm.pools.<name>.settings") | ||
| (mkRemovedOptionModule [ | ||
| "services" | ||
| "matomo" | ||
| "phpfpmProcessManagerConfig" | ||
| ] | ||
| "Use services.phpfpm.pools.<name>.settings") | ||
| (mkRenamedOptionModule [ | ||
| "services" | ||
| "piwik" | ||
| "nginx" | ||
| ] [ | ||
| "services" | ||
| "matomo" | ||
| "nginx" | ||
| ]) |
There was a problem hiding this comment.
I can't emphasize enough how in my opinion the formatting in this block is not an improvement 馃槙
To be clear, though, the rest of the file is fine... again, in my opinion 馃槃
There was a problem hiding this comment.
that one specifically is what I had in mind when I made my comment about lists. 馃槃 I think nixpkgs-fmt did half of them and it was somehow worse so I did the rest so it wouldn't keep messing with it ( and that's how lists are supposed to be anyway but the reasoning probably doesn't matter here so :| ) I switched nixops-digitalocean to nixfmt since lol I found that one by accident there are a lot more in nixpkgs that it will rewrite every time. ...which seems problematic if it's meant to be put in git hooks? idk
ANYWAY I'll do something about that one and I'll see about release notes too. then I can check the documentation box for once.
|
Still problem with this derivation is that some things do not work, as the directories are read-only, e.g. Geo-IP db updates or plugin installations. Imho all changeable data should reside below $dataDir. There already is a PR to fix this for GeoIP. #100617 but basically this is an upstream problem. |
| } | ||
| ) | ||
| ); | ||
| type = types.nullOr (types.submodule (recursiveUpdate |
There was a problem hiding this comment.
Those whitespace changes unnecessarily pollute the file history IMO.
|
Matomo package is now on version 4.2.1 in master - Is this PR still relevant? |
i might have a problem with compulsive formatting (especially w.r.t. lists)
there should probably be a note somewhere about a manual database upgrade step that should be done (this is the note)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)various versions of 4.0.x (beta versions too. currently this PR, 4.0.4) have been running on my server for a few weeks now. I tested upgrades and new installs (on... 4.0.1 i think) in a vm.
there may be a change to how it handles reverse proxies I'm not sure. also not sure if a module change is in order or not. (it doesn't like letting me log into matomo.$domain but stats.$domain is fine. it might not have liked matomo.$domain before either, I don't remember. too late for me to check now 馃槃 )
@florianjacob @aanderse