Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: Update #105979

Closed
wants to merge 6 commits into from
Closed

zoom-us: Update #105979

wants to merge 6 commits into from

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Update package - This is not working yet, @danbst @tadfisher - It segfaults with this in the log:

Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
[CZPClientLogMgr::LogClientEnvironment] [MacAddr: ...][client: Linux][OS: NixOS 21.03 (Okapi)][Hardware: CPU Core:4 Frenquency:1.8 G Memory size:15833MB CPU Brand:Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz GPU Brand:][Req ID: ]
Linux Client Version is 5.4.54779.1115
QSG_RENDER_LOOP is 
XDG_CURRENT_DESKTOP = GNOME;   GDMSESSION = gnome
Client: Breakpad is using Client-Server Mode! client fd = 3
Error: Send error, 22 Invalid argument
Error: Send error, 22 Invalid argument
Error: Send error, 22 Invalid argument
Graphics Card Info:: 00:02.0 VGA compatible controller: Intel Corporation UHD Graphics 620 (Whiskey Lake) (rev 02)
Zoom package arch is 64bit, runing OS arch is x86_64

IDK what to do :(.

However I made the update script act as expected - it needed a change due to how their website changed a bit the format of the version string.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from danbst and tadfisher December 5, 2020 14:24
@doronbehar
zoom-us: Make update script get exact version
0e3e969 
Their website has changed the format in which they display the version,
into something a bit more sophisticated.
@doronbehar doronbehar changed the title Pkg/zoom us zoom-us: Update Dec 12, 2020
@doronbehar doronbehar mentioned this pull request Dec 23, 2020
Open
9 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/show-case-for-nix-ld-run-umodified-zoom/11004/1

@Mic92
Copy link
Member

Mic92 commented Jan 17, 2021

I chose a different approach in #109602
Seems to work so far.

@doronbehar doronbehar closed this Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst Awaiting requested review from danbst

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @nixos-discourse @Mic92