Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickfix: init at 1.15.1 #105843

Merged
merged 1 commit into from Jan 14, 2021
Merged

quickfix: init at 1.15.1 #105843

merged 1 commit into from Jan 14, 2021

Conversation

HectorAE
Copy link
Contributor

@HectorAE HectorAE commented Dec 4, 2020

Motivation for this change

This is a common library used in the financial industry, used for processing securities trade data.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bhipple December 4, 2020 02:48
RaghavSood
RaghavSood requested changes Dec 4, 2020
View reviewed changes
pkgs/development/libraries/quickfix/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/quickfix/default.nix Show resolved Hide resolved
pkgs/development/libraries/quickfix/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/quickfix/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/quickfix/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/quickfix/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105843 run on x86_64-linux 1

1 package built:
  • quickfix

@ofborg ofborg bot requested a review from bhipple January 13, 2021 02:30
@SuperSandro2000 SuperSandro2000 merged commit 6e7846b into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@RaghavSood RaghavSood RaghavSood requested changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HectorAE @SuperSandro2000 @RaghavSood @Ericson2314 @bhipple