Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackage.zeal-user-contrib: init at 1.1.0 #105844

Closed
wants to merge 1 commit into from
Closed

nodePackage.zeal-user-contrib: init at 1.1.0 #105844

wants to merge 1 commit into from

Conversation

trepetti
Copy link
Contributor

@trepetti trepetti commented Dec 4, 2020

Motivation for this change

This CLI utility lets Zeal offline documentation browser uses pull in user contributions more easily.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trepetti trepetti closed this Dec 4, 2020
@trepetti
Copy link
Contributor Author

trepetti commented Dec 4, 2020

Looks like mass update script introduced some issues, so I will hold off on this.

@trepetti trepetti deleted the zeal-user-contrib branch December 6, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@trepetti