fetchzip: get write permission on unpacked directory #105845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for NixOS/nix#4295, which caused single-user Linux Nix installations using sandboxed builds to start failing to build fetchzip derivations after 4a5c493. In short: removing write permissions for the entire directory is great, except we then can't rename(2) it to the final Nix store path out of the sandbox, because we don't have write permission on the directory and thus cannot update the ".." directory entry.
|
Result of (This one on NixOS) |
|
Result of (This one on Ubuntu 20.04 with a single-user Nix install) |
|
@lukegb the review links are to https://github.com/Mic92/nixpkgs-review |
|
Yeah, they would be. Basically, nixpkgs-review didn't rebuild anything because "nothing" changed. |
|
Amazing! Thanks for finding the regression. Does nixpkgs or Nix itself have any single-user testing setup? |
fzakaria
reviewed
Dec 4, 2020
fzakaria
approved these changes
Dec 4, 2020
bhipple
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a workaround for NixOS/nix#4295, which caused single-user Linux
Nix installations using sandboxed builds to start failing to build
fetchzip derivations after 4a5c493.
In short: removing write permissions for the entire directory is great,
except we then can't rename(2) it to the final Nix store path out of the
sandbox, because we don't have write permission on the directory and
thus cannot update the ".." directory entry.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @abathur @bhipple @MetaDark @fzakaria