Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idevicerestore to 1.0.0 (+ required libraries to latest stable releases) #105846

Merged
merged 9 commits into from Dec 7, 2020

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Dec 4, 2020

Motivation for this change

It's been a few months and there is a new stable upstream release (1.0.0).
Since idevicerestore depends on the libraries, I wasn't sure if I should split this into multiple commits or leave it as a single one. Feedback very welcome!

nixpkgs % result/bin/idevicerestore
Usage: idevicerestore [OPTIONS] PATH

Restore IPSW firmware at PATH to an iOS device.

PATH can be a compressed .ipsw file or a directory containing all files
extracted from an IPSW.

OPTIONS:
  -i, --ecid ECID       Target specific device by its ECID
                        e.g. 0xaabb123456 (hex) or 1234567890 (decimal)
  -u, --udid UDID       Target specific device by its device UDID
                        NOTE: only works with devices in normal mode.
  -l, --latest          Use latest available firmware (with download on demand).
                        Before performing any action it will interactively ask
                        to select one of the currently signed firmware versions,
                        unless -y has been given too.
                        The PATH argument is ignored when using this option.
                        DO NOT USE if you need to preserve the baseband/unlock!
                        USE WITH CARE if you want to keep a jailbreakable
                        firmware!
  -e, --erase           Perform full restore instead of update, erasing all data
                        DO NOT USE if you want to preserve user data on the device!
  -y, --no-input        Non-interactive mode, do not ask for any input.
                        WARNING: This will disable certain checks/prompts that
                        are supposed to prevent DATA LOSS. Use with caution.
  -n, --no-action       Do not perform any restore action. If combined with -l
                        option the on-demand ipsw download is performed before
                        exiting.
  -h, --help            Prints this usage information
  -C, --cache-path DIR  Use specified directory for caching extracted or other
                        reused files.
  -d, --debug           Enable communication debugging
  -v, --version         Print version information

Advanced/experimental options:
  -c, --custom          Restore with a custom firmware (requires bootrom exploit)
  -s, --cydia           Use Cydia's signature service instead of Apple's
  -x, --exclude         Exclude nor/baseband upgrade
  -t, --shsh            Fetch TSS record and save to .shsh file, then exit
  -z, --no-restore      Do not restore and end after booting to the ramdisk
  -k, --keep-pers       Write personalized components to files for debugging
  -p, --pwn             Put device in pwned DFU mode and exit (limera1n devices)
  -P, --plain-progress  Print progress as plain step and progress
  -R, --restore-mode    Allow restoring from Restore mode
  -T, --ticket PATH     Use file at PATH to send as AP ticket

Homepage:    <https://libimobiledevice.org>
Bug Reports: <https://github.com/libimobiledevice/idevicerestore/issues>

% result/bin/idevicerestore -v
idevicerestore 1.0.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Since idevicerestore depends on the libraries, I wasn't sure if I should split this into multiple commits or leave it as a single one.

Please do one commit per package update to easily backport or revert those commits if necessary.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of those libraries tag releases?

@rb2k
Copy link
Contributor Author

rb2k commented Dec 4, 2020

Do any of those libraries tag releases?

I guess the answer is: kind of :)

idevicerestore only has a single tag (1.0.0) that they recently released.
libirecovery had some more (https://github.com/libimobiledevice/libirecovery/releases), but it's also just a 1.0.0 and then very minor stuff from 2013

My tags are all for the 1.0.0 release. It's hard to say if they will go forward and tag releases with any regularity.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 4, 2020

@SuperSandro2000 ok, they are now 1 commit per update (1 per library + 1 for the binary)

@rb2k rb2k changed the title Update idevicerestore and required libraries to latest stable releases. Update idevicerestore to 1.0.0 (+ required libraries to latest stable releases) Dec 5, 2020
@nh2
Copy link
Contributor

nh2 commented Dec 5, 2020

@GrahamcOfBorg build libplist libusbmuxd libirecovery libimobiledevice idevicerestore

@nh2
Copy link
Contributor

nh2 commented Dec 5, 2020

@rb2k If you use commit messagess like packagename: 1.2.3 -> 4.5.6, then the ofborg CI will automatically try to build your changes without manual action.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 5, 2020

@rb2k If you use commit messagess like packagename: 1.2.3 -> 4.5.6, then the ofborg CI will automatically try to build your changes without manual action.

Thanks for the heads up, I'm still new to the nixpkgs review workflow :)
Should I change and force push or do you think it's fine to leave it as is for now?

Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, ofborg is happy with the update.

Please update the commit messages accordingly (example: b949937), then this should be merged.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 5, 2020

Too much mercurial at $DAYJOB, trying to revive git memory. Give me a few minutes :D

@nh2
Copy link
Contributor

nh2 commented Dec 5, 2020

Should I change and force push or do you think it's fine to leave it as is for now?

@rb2k Yes, changing (usually with git rebase --interactive) and force-pushing is right.

I think your last force-push wasn't as intended though, e.g. https://github.com/NixOS/nixpkgs/pull/105846/commits currently shows 12 commits, one of them being a merge commit.

Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah bummer, NIX_PATH=nixpkgs=. nixpkgs-review pr --post-result --checkout commit 105846 shows that 2 packages that depend on this update newly fail (they don't fail on master):

builder for '/nix/store/srn8ghng75qd8zla37d867g3wxxzx0rc-usbmuxd-2019-11-11.drv' failed with exit code 1; last 10 log lines:
  
  No package 'libplist' found
builder for '/nix/store/h4gv10gfy2l6s36y5fdd82c7ik2vdbq2-libgpod-0.8.3.drv' failed with exit code 1; last 10 log lines:
  
  No package 'libplist' found

Maybe libplist changed its pkg-config .pc file somehow?


Edit:

In more detail:

libgpod fails with:

checking for LIBGPOD... no
configure: error: Package requirements (glib-2.0 >= 2.16.0 gobject-2.0 sqlite3 libplist >= 1.0 gmodule-2.0) were not met:

No package 'libplist' found

Odd message checking for LIBGPOD... no, given that that's the name of the library itself, but it checks for libplist.

On nixos-unstable it looks like this:

checking for LIBGPOD... yes

On usbmuxd:

checking for libplist >= 1.11... no
configure: error: Package requirements (libplist >= 1.11) were not met:

No package 'libplist' found

On nixos-unstable it looks like this:

checking for libplist >= 1.11... yes

@rb2k
Copy link
Contributor Author

rb2k commented Dec 6, 2020

@SuperSandro2000 just for me to clarify: why are we removing the sha256 fields? Seems like in most other places those are still present, even when using tags with fetchFromGitHub

@SuperSandro2000
Copy link
Member

why are we removing the sha256 fields?

I am not proposing this. My proposal is about replacing the hardcoded version in fetchFromGitHub with the version already defined earlier which enables easier updates.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 6, 2020

ok, that seemed weird. Github also redlined the 'rev' lines for me as well.

Either way, replaced the version strings with the previously defined version :)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105846 run on x86_64-darwin 1

16 packages marked as broken and skipped:
  • almanah
  • atom
  • atom-beta
  • gnome-recipes
  • gnome3.nautilus-python
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • mate.mate-power-manager
  • xfce.xfce4-weather-plugin
  • xfce.xfce4_weather_plugin
7 packages built:
  • ideviceinstaller
  • idevicerestore
  • libimobiledevice
  • libirecovery
  • libplist
  • libusbmuxd
  • usbmuxd

@rb2k
Copy link
Contributor Author

rb2k commented Dec 7, 2020

I'm running a linux run as well. Currently on 82 of 133 :)

[1/82/133 built, 0.0 MiB DL] building adapta-gtk-theme-3.95.0.11 (buildPhase): Rendering ../assets-gtk2/ProgressBar/bar.png

@nh2
Copy link
Contributor

nh2 commented Dec 7, 2020

Just to clarify, I would just have to run nixpkgs-review pr 105846 and wait for a while to see if there's any other packages that are colliding?

@rb2k Yes, though I usually use the NIX_PATH=nixpkgs=. nixpkgs-review pr --checkout commit 105846; the --checkout option makes sure that it uses exactly the commit in your PR, instead of putting your PR on top of current master (thus being more reproducible).

is that something that ofbord would already have done as well?

Ofborg only builds the packages at the beginning of your commit messages, or what is manually started by @grahamcofborg build package1 package2 github comments. nixpkgs-review builds everything that is recursively changed by your change.

For example, if you change glibc, then ofborg will build glibc, and nixpkgs-review will build the world.

Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the remaining nixpkgs-review failures are only marked-as-broken packages (thus also on master):

16 packages marked as broken and skipped:

I think we're good to go here.

@SuperSandro2000 are all the changes you requested done?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 7, 2020

@rb2k Yes, though I usually use the NIX_PATH=nixpkgs=. nixpkgs-review pr --checkout commit 105846; the --checkout option makes sure that it uses exactly the commit in your PR, instead of putting your PR on top of current master (thus being more reproducible).

which is not what we want because the could lead to immediate failures after merging. Otherwise we would need to rebase PRs before merging. Please do not run nixpkgs-review with your modified NIX_PATH or otherwise I can't really trust it.

I think we're good to go here.

Not really. This is nixpkgs-review on darwin which only build a 10th of the rebuilds on linux.

@rb2k
Copy link
Contributor Author

rb2k commented Dec 7, 2020

My linux based nixpkgs-review run finished and I think this means 'everything ok'?:

marc@thesilence:~/nixpkgs> nixpkgs-review pr 105846
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/105846/head:refs/nixpkgs-review/1
$ git worktree add /home/marc/.cache/nixpkgs-review/pr-105846-9/nixpkgs 30526f59a11838a45af8031c90ebf818aa74225e
Preparing worktree (detached HEAD 30526f59a11)
Updating files: 100% (23446/23446), done.
HEAD is now at 30526f59a11 ocamlPackages.lambdasoup: 0.7.1 -> 0.7.2
$ nix-env -f /home/marc/.cache/nixpkgs-review/pr-105846-9/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 51f54e1a5de9fe815dd42198c6d1efac6d384cca
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/marc/.cache/nixpkgs-review/pr-105846-9/nixpkgs -qaP --xml --out-path --show-trace --meta
151 packages updated:
adapta-gtk-theme almanah atom atom-beta bubblemail calls cheese chrome-gnome-shell cinnamon-common cinnamon-control-center cinnamon-gsettings-overrides cinnamon-screensaver cinnamon-session cinnamon-settings-daemon cjs-unstable clementine-blob clementine-free clight dropbox-cli elementary-calendar elementary-dpms-helper elementary-greeter elementary-gsettings-desktop-schemas elementary-music elementary-planner elementary-session-settings-unstable elementary-settings-daemon empathy eolie evolution evolution-data-server evolution-data-server evolution-ews extra-elementary-contracts far2l feedreader file-roller folks gala geary gfbgraph gigolo gnome-applets gnome-books gnome-boxes gnome-calendar gnome-contacts gnome-control-center gnome-disk-utility gnome-documents gnome-flashback gnome-initial-setup gnome-maps gnome-music gnome-notes gnome-online-accounts gnome-online-miners gnome-panel gnome-photos gnome-power-manager gnome-recipes gnome-session gnome-settings-daemon gnome-shell gnome-shell-extension-EasyScreenCast-unstable gnome-shell-extension-night-theme-switcher gnome-shell-gsconnect gnome-shell-pomodoro gnome-shell-system-monitor gnome-software gnome-terminal gnome-todo gnome-tweaks gnome-user-share gpaste grilo-plugins gtkpod gvfs gvfs gvfs ideviceinstaller (2018-10-01 → 1.1.1) idevicerestore (2019-12-26 → 1.0.0) ifuse (2018-10-08 → 1.1.4) kodi kodi kodi kodi-platform kodi-plugin-inputstream-adaptive kodi-plugin-peripheral.joystick kodi-plugin-peripheral.steamcontroller kodi-plugin-pvr-hdhomerun kodi-plugin-pvr-hts kodi-plugin-pvr-iptvsimple kodi-plugin-vfs.libarchive kodi-plugin-vfs.sftp kodi-wayland kodi-wayland-with-plugins kodi-with-plugins kodi-with-plugins kodi-with-plugins libgdata libgpod libimobiledevice (2020-01-20 → 1.3.0) libirecovery (2020-01-14 → 1.0.0) libplist (2019-04-04 → 2.2.0) libusbmuxd (2019-03-23 → 2.0.2) libzapojit mailnag mate-applets mate-power-manager mate-tweak mixxx monitor mutter mutter nautilus nautilus-python rabbitvcs shotwell switchboard switchboard-plug-mouse-touchpad switchboard-plug-pantheon-shell switchboard-plug-power thermald thunar thunar thunar-archive-plugin thunar-dropbox totem tracker-miners upower usbmuxd (2019-11-11 → 1.1.1) wingpanel wingpanel wingpanel-applications-menu wingpanel-indicator-bluetooth-unstable wingpanel-indicator-datetime wingpanel-indicator-keyboard wingpanel-indicator-network wingpanel-indicator-nightlight wingpanel-indicator-notifications wingpanel-indicator-power wingpanel-indicator-session-unstable wingpanel-indicator-sound xdg-desktop-portal-gtk xfce4-power-manager xfce4-settings xfce4-weather-plugin xfdesktop xmonad-log-applet-gnomeflashback-unstable xmonad-log-applet-gnomeflashback-unstable

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/marc/.cache/nixpkgs-review/pr-105846-9/build.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/105846

4 packages marked as broken and skipped:
gnome3.gnome-books gnome3.gnome-documents xmonad_log_applet xmonad_log_applet_gnome3

143 packages built:
adapta-gtk-theme almanah atom atom-beta bubblemail calls chrome-gnome-shell cinnamon.cinnamon-common cinnamon.cinnamon-control-center cinnamon.cinnamon-gsettings-overrides cinnamon.cinnamon-screensaver cinnamon.cinnamon-session cinnamon.cinnamon-settings-daemon cinnamon.cjs clementine clementineUnfree clight dropbox-cli elementary-planner empathy eolie evolution-data-server evolution-ews far2l feedreader folks gfbgraph gnome-online-accounts gnome-photos gnome-recipes gnome2.gvfs gnome3.bijiben gnome3.cheese gnome3.evolution gnome3.file-roller gnome3.geary gnome3.gnome-applets gnome3.gnome-boxes gnome3.gnome-calendar gnome3.gnome-contacts gnome3.gnome-control-center gnome3.gnome-disk-utility gnome3.gnome-flashback gnome3.gnome-initial-setup gnome3.gnome-maps gnome3.gnome-music gnome3.gnome-online-miners gnome3.gnome-panel gnome3.gnome-power-manager gnome3.gnome-session gnome3.gnome-settings-daemon gnome3.gnome-shell gnome3.gnome-software gnome3.gnome-terminal gnome3.gnome-todo gnome3.gnome-tweak-tool gnome3.gnome-user-share gnome3.gpaste gnome3.grilo-plugins gnome3.gvfs gnome3.libgdata gnome3.libzapojit gnome3.mutter gnome3.mutter334 gnome3.nautilus gnome3.nautilus-python gnome3.pomodoro gnome3.shotwell gnome3.totem gnome3.tracker-miners gnomeExtensions.easyScreenCast gnomeExtensions.gsconnect gnomeExtensions.night-theme-switcher gnomeExtensions.system-monitor gtkpod ideviceinstaller idevicerestore ifuse kodi kodi-gbm kodi-wayland kodiGBM kodiPlain kodiPlainWayland kodiPlugins.inputstream-adaptive kodiPlugins.joystick kodiPlugins.kodi-platform kodiPlugins.pvr-hdhomerun kodiPlugins.pvr-hts kodiPlugins.pvr-iptvsimple kodiPlugins.steam-controller kodiPlugins.vfs-libarchive kodiPlugins.vfs-sftp libgpod libimobiledevice libirecovery libplist libusbmuxd mailnagWithPlugins mate.mate-applets mate.mate-power-manager mate.mate-tweak mixxx monitor pantheon.elementary-calendar pantheon.elementary-dpms-helper pantheon.elementary-greeter pantheon.elementary-gsettings-schemas pantheon.elementary-music pantheon.elementary-session-settings pantheon.elementary-settings-daemon pantheon.extra-elementary-contracts pantheon.gala pantheon.switchboard-plug-mouse-touchpad pantheon.switchboard-plug-pantheon-shell pantheon.switchboard-plug-power pantheon.switchboard-with-plugs pantheon.wingpanel pantheon.wingpanel-applications-menu pantheon.wingpanel-indicator-bluetooth pantheon.wingpanel-indicator-datetime pantheon.wingpanel-indicator-keyboard pantheon.wingpanel-indicator-network pantheon.wingpanel-indicator-nightlight pantheon.wingpanel-indicator-notifications pantheon.wingpanel-indicator-power pantheon.wingpanel-indicator-session pantheon.wingpanel-indicator-sound pantheon.wingpanel-with-indicators rabbitvcs thermald upower usbmuxd xdg-desktop-portal-gtk xfce.gigolo xfce.gvfs xfce.thunar xfce.thunar-archive-plugin xfce.thunar-dropbox-plugin xfce.xfce4-power-manager xfce.xfce4-settings xfce.xfce4-weather-plugin xfce.xfdesktop

$ nix-shell /home/marc/.cache/nixpkgs-review/pr-105846-9/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-105846-9]$ 

Only thing I have to do is change my email in the commit since this is a bit of a work thing :)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105846 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • xmonad_log_applet
143 packages built:
  • adapta-gtk-theme
  • almanah
  • atom
  • atom-beta
  • bubblemail
  • calls
  • chrome-gnome-shell
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-control-center
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • cinnamon.cinnamon-session
  • cinnamon.cinnamon-settings-daemon
  • cinnamon.cjs
  • clementine
  • clementineUnfree
  • clight
  • dropbox-cli
  • elementary-planner
  • empathy (gnome3.empathy)
  • eolie
  • evolution-data-server (gnome3.evolution-data-server ,gnome3.evolution_data_server)
  • evolution-ews
  • far2l
  • feedreader
  • folks (gnome3.folks)
  • gfbgraph (gnome3.gfbgraph)
  • gnome-online-accounts (gnome3.gnome-online-accounts ,gnome3.gnome_online_accounts)
  • gnome-photos (gnome3.gnome-photos)
  • gnome-recipes
  • gvfs (gnome2.gvfs)
  • gnome3.bijiben (gnome3.gnome-notes)
  • gnome3.cheese
  • gnome3.evolution
  • gnome3.file-roller
  • gnome3.geary
  • gnome3.gnome-applets
  • gnome3.gnome-boxes
  • gnome3.gnome-calendar
  • gnome3.gnome-contacts
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-disk-utility
  • gnome3.gnome-flashback
  • gnome3.gnome-initial-setup
  • gnome3.gnome-maps
  • gnome3.gnome-music
  • gnome3.gnome-online-miners
  • gnome3.gnome-panel
  • gnome3.gnome-power-manager
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-settings-daemon (gnome3.gnome_settings_daemon)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-software
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-todo
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.gnome-user-share
  • gnome3.gpaste
  • grilo-plugins (gnome3.grilo-plugins)
  • gnome3.gvfs
  • libgdata (gnome3.libgdata)
  • libzapojit (gnome3.libzapojit)
  • gnome3.mutter
  • pantheon.mutter (gnome3.mutter334)
  • gnome3.nautilus
  • gnome3.nautilus-python
  • gnome3.pomodoro
  • shotwell (gnome3.shotwell)
  • gnome3.totem
  • tracker-miners (gnome3.tracker-miners)
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • gnomeExtensions.system-monitor
  • gtkpod
  • ideviceinstaller
  • idevicerestore
  • ifuse
  • kodi
  • kodi-gbm
  • kodi-wayland
  • kodiGBM
  • kodiPlain (kodiPlugins.kodi)
  • kodiPlainWayland
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.kodi-platform
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • libgpod
  • libimobiledevice
  • libirecovery
  • libplist
  • libusbmuxd
  • mailnagWithPlugins
  • mate.mate-applets
  • mate.mate-power-manager
  • mate.mate-tweak
  • mixxx
  • monitor
  • pantheon.elementary-calendar
  • pantheon.elementary-dpms-helper
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-music
  • pantheon.elementary-session-settings
  • pantheon.elementary-settings-daemon
  • pantheon.extra-elementary-contracts
  • pantheon.gala
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators
  • rabbitvcs
  • thermald
  • upower
  • usbmuxd
  • xdg-desktop-portal-gtk
  • xfce.gigolo
  • xfce.gvfs
  • xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
  • xfce.thunar-archive-plugin
  • xfce.thunar-dropbox-plugin
  • xfce.xfce4-power-manager (xfce.xfce4_power_manager ,xfce.xfce4_power_manager_gtk3)
  • xfce.xfce4settings (xfce.xfce4-settings)
  • xfce.xfce4-weather-plugin (xfce.xfce4_weather_plugin)
  • xfce.xfdesktop

@SuperSandro2000 SuperSandro2000 merged commit d836655 into NixOS:master Dec 7, 2020
@nh2
Copy link
Contributor

nh2 commented Dec 8, 2020

which is not what we want because the could lead to immediate failures after merging. Otherwise we would need to rebase PRs before merging. Please do not run nixpkgs-review with your modified NIX_PATH or otherwise I can't really trust it.

@SuperSandro2000 There's certainly merit on trying to build on current master, but that's not reproducible, and I think it's useful to first test the PR itself to exclude that something new in master is the actual failure reason. It's not possible to guarantee clean builds with nixpkgs-review especially for large builds, as nixpkgs advances faster than we can build stuff (e.g. every 10 minutes currently; the more recent, the less likely the breakage is of course).

Not really. This is nixpkgs-review on darwin which only build a 10th of the rebuilds on linux.

Ah sorry, I had not spotted the platform in your comment.

@nh2
Copy link
Contributor

nh2 commented Dec 8, 2020

Thanks for the big update, @rb2k!

@SuperSandro2000
Copy link
Member

to first test the PR itself to exclude that something new in master is the actual failure reason.

If something in master failed breaks the PR than it is broken after we merged it and we did not gain anything and maybe even broke master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants