When moving paths out of sandbox, ensure we have write permission #4312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're a single-user installation of Nix, then we won't have root superpowers to just ignore the permission bits. This means that we'll need permission on the directory (if it's a directory) that we're moving in order to move it with rename, because it must update the ".." directory entry.
Fixes #4295.
This is already working in master, thanks to e913a29 (and followup cleanups).
I didn't change the other instances of
rename
here to make this diff as minimal as possible.