New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codechange: Drop libxdg-basedir dependency in favour of finding the directories ourselves #8357
Conversation
29e8d2e
to
8deaf5a
Compare
8deaf5a
to
dd28786
Compare
dd28786
to
1032722
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency is a bit of a pain, and iirc @matthijskooijman expressed interest in dropping the package from debian entirely anyway.
I don't really recall this and could not find any evidence, but looking in Ubuntu, there's only a handful packages left using libxdg-basedir, so I guess it's on its way to removal anyway, so +1.
1032722
to
fb5daaa
Compare
Something to consider:
No need to do this in this PR. It just jumped out for me :) |
fb5daaa
to
09f586b
Compare
c5b7cfe
to
29b4b75
Compare
…irectories ourselves
29b4b75
to
fab9405
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find anything else to bitch about :(
The dependency is a bit of a pain, and iirc @matthijskooijman expressed interest in dropping the package from debian entirely anyway.
And given replacing the dependency takes so little effort anyway...
Ideally the whole
Determine(Base)Path
stuff would be replaced with something that didn't rely on a load of manual string manipulation, but that's for later...