Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

razergenie: 0.8.1 -> 0.9.0 #106090

Merged
merged 1 commit into from Jan 16, 2021
Merged

razergenie: 0.8.1 -> 0.9.0 #106090

merged 1 commit into from Jan 16, 2021

Conversation

mogria
Copy link
Contributor

@mogria mogria commented Dec 6, 2020

Motivation for this change

The Developer released version 0.9 https://github.com/z3ntu/RazerGenie/releases/tag/v0.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mogria
razergenie: 0.8.1 -> 0.9.0
e922efa 
Upstream released a new version in september with new matrix layout
features & some fixes.
@WolfangAukang
Copy link
Contributor

WolfangAukang commented Jan 16, 2021 •
edited

Result of nixpkgs-review pr 106090 run on x86_64-linux 1

1 package built:
  • razergenie

Application running fine and code LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/331

@AndersonTorres AndersonTorres merged commit cbf1777 into NixOS:master Jan 16, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 16, 2021
View reviewed changes
pkgs/applications/misc/razergenie/default.nix
@@ -35,7 +35,7 @@ in stdenv.mkDerivation {
homepage = "https://github.com/z3ntu/RazerGenie";
description = "Qt application for configuring your Razer devices under GNU/Linux";
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to update the license to gpl3only or gpl3plus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@WolfangAukang WolfangAukang WolfangAukang approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mogria @WolfangAukang @nixos-discourse @SuperSandro2000 @AndersonTorres