Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.markup: 0.8.2 -> 1.0.0, ocamlPackages.lambdasoup: 0.7.1 -> 0.7.2 #106078

Closed
wants to merge 3 commits into from
Closed

ocamlPackages.markup: 0.8.2 -> 1.0.0, ocamlPackages.lambdasoup: 0.7.1 -> 0.7.2 #106078

wants to merge 3 commits into from

Conversation

sternenseemann
Copy link
Member

Motivation for this change

#106069 (review)

cc @vbgl (lambdasoup) @FlorentBecker (markup)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann changed the title Markup 1.0.0 ocamlPackages.markup: 0.8.2 -> 1.0.0, ocamlPackages.lambdasoup: 0.7.1 -> 0.7.2 Dec 6, 2020
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.lambdasoup

@vbgl
Copy link
Contributor

vbgl commented Dec 6, 2020

Merged into master as 1f850a0, 2830a80, and 30526f5.

@vbgl vbgl closed this Dec 6, 2020
@sternenseemann sternenseemann deleted the markup-1.0.0 branch December 6, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl