Improve static Nix Darwin support #106115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can’t do fully static here, like "static" flag in libev does. I’m not 100% sure if this is necessary for Linux (makeStaticBinaries should set -static flag automatically), but leaving as is to avoid breaking anything.
This needs to go first since the .override will reset the mkDerivation function, removing any other customisations done afterwards. Kind of hacky, but seems to work correctly right now.
ofborg
bot
added
6.topic: darwin
matthewbauer
added a commit
to matthewbauer/nix
that referenced
this pull request
Dec 6, 2020
This depends on a PR not merged into Nixpkgs. This commit should not be merged until that PR is done. PR: NixOS/nixpkgs#106115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
These changes are what's needed for
pkgsStatic.nixto build on x86_64-darwin.Things done
./result/bin/)nix path-info -Sbefore and after)