Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan-validation-layers: fix bug related to XDG_DATA_DIRS #106085

Merged
merged 3 commits into from Mar 22, 2021
Merged

vulkan-validation-layers: fix bug related to XDG_DATA_DIRS #106085

merged 3 commits into from Mar 22, 2021

Conversation

loewenheim
Copy link
Contributor

Motivation for this change

Fix issue #89816 as suggested there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Ralith December 6, 2020 18:55
@jonringer
Copy link
Contributor

The whole setup hook might not be needed after: #103501

You will just need vulkan-validation-layers listed as a nativeBuildInput

@loewenheim
Copy link
Contributor Author

All the better. Is that change going to be available on 20.09?

@jonringer
Copy link
Contributor

All the better. Is that change going to be available on 20.09?

probably, I wanted some time for it to "bake" in master to ensure that it's working as intended.

@tcmal
Copy link
Member

tcmal commented Jan 10, 2021

Can this be merged? Am currently encountering target/lorri#262 which seems to be blocked by this.

kanashimia
kanashimia suggested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@kanashimia kanashimia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing setupHook all together does indeed work now, so should probably do that.

@ofborg ofborg bot requested a review from Ralith February 25, 2021 10:04
@loewenheim
Copy link
Contributor Author

Someone else will have to merge it, I don't have rights :)

@ofborg ofborg bot requested a review from Ralith March 14, 2021 15:22
@SuperSandro2000 SuperSandro2000 merged commit ed9ddeb into NixOS:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

@kanashimia kanashimia kanashimia approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@loewenheim @jonringer @tcmal @Ralith @kanashimia @SuperSandro2000