Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python39Package.fs: fix tests #106083

Merged
merged 1 commit into from Dec 7, 2020
Merged

python39Package.fs: fix tests #106083

merged 1 commit into from Dec 7, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 6, 2020 •
edited

Motivation for this change

saw it was broken in #106054

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner December 6, 2020 18:02
@jonringer
Copy link
Contributor Author

all of these were failing before:

https://github.com/NixOS/nixpkgs/pull/106083
2 packages failed to build:
python39Packages.afdko python39Packages.nototools

11 packages built:
python39Packages.booleanoperations python39Packages.defcon python39Packages.fontmath python39Packages.fontparts python39Packages.fontpens python39Packages.fonttools python39Packages.fs python39Packages.fs-s3fs python39Packages.mutatormath python39Packages.psautohint python39Packages.ufoprocessor

@sternenseemann
Copy link
Member

LGTM, afdko failure seems unrelated, will have to investigate.

@jonringer jonringer merged commit f70e166 into NixOS:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @sternenseemann