Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pikopixel: init at 1.0-b9e #106102

Merged
merged 2 commits into from Jan 19, 2021
Merged

pikopixel: init at 1.0-b9e #106102

merged 2 commits into from Jan 19, 2021

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Dec 6, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'm having some problems with the application: the auxiliary windows constantly appear and disappear when clicking. I'm not sure if that's due to my window manager setup, so it'd be nice if someone with gnome/kde/something else tested it.
EDIT: I tested it on GNOME, and there are no issues, so it's just my setup.

Finally, I have no idea how to build this for darwin, and ofborg is down, so any help for that platform is appreciated. Is it just a matter of adding xcbuild to nativeBuildInputs?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106102 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • openvpn-auth-ldap
  • pikopixel
2 packages failed to build:
  • gnustep.libobjc
  • gnustep.make
1 package built:
  • gnustep.stdenv

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106102 run on x86_64-linux 1

1 package failed to build and are new build failure:
15 packages built:
  • bookworm
  • gnustep.back
  • gnustep.base
  • gnustep.gorm
  • gnustep.gui
  • gnustep.gworkspace
  • gnustep.libobjc
  • gnustep.make
  • gnustep.projectcenter
  • gnustep.system_preferences
  • hopper
  • pikopixel
  • sogo
  • sope
  • unar

@fgaz
Copy link
Member Author

fgaz commented Jan 18, 2021

openvpn-auth-ldap is not a new failure: https://hydra.nixos.org/build/135254974

@SuperSandro2000
Copy link
Member

openvpn-auth-ldap is not a new failure: hydra.nixos.org/build/135254974

The check was faulty. On new runs it show the correct.

@SuperSandro2000 SuperSandro2000 merged commit 550ff33 into NixOS:master Jan 19, 2021
@fgaz fgaz deleted the pikopixel/init branch January 19, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ashalkhakov ashalkhakov Awaiting requested review from ashalkhakov

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @SuperSandro2000