Fix redirect from / to /packages breaking browser back button #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, navigating to https://search.nixos.org/ would use history.pushState to redirect to /packages and add a new entry to the browser history. This meant that if you pressed the back button, you would navigate back to / which would of course then redirect to /packages again. Now history.replaceState is used instead of pushState, so the / history entry is replaced entirely by a /packages history entry and the back button works.
|
For some reason the Netlify deployment is failing even after I add NETLIFY_AUTH_TOKEN and NETLIFY_SITE_ID to my repo's secrets? Could be because of this line? nixos-search/.github/workflows/main.yml Line 56 in 27ff900 |
|
@bmwalters thank you for fixing this. Using The preview links are only generated when created from the branch on this repo. If you are planning to contribute more to |
garbas
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, navigating to https://search.nixos.org/ would use history.pushState
to redirect to /packages and add a new entry to the browser history.
This meant that if you pressed the back button, you would navigate back to /
which would of course then redirect to /packages again.
Now history.replaceState is used instead of pushState, so the / history entry
is replaced entirely by a /packages history entry and the back button works.