Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.12.05 -> 2020.12.07 #106087

Merged
merged 1 commit into from Dec 7, 2020
Merged

youtube-dl: 2020.12.05 -> 2020.12.07 #106087

merged 1 commit into from Dec 7, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Dec 6, 2020

Motivation for this change

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.12.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 7, 2020
AndersonTorres
AndersonTorres approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTBorg

@AndersonTorres AndersonTorres merged commit 1774839 into NixOS:master Dec 7, 2020
@Luflosi Luflosi deleted the update/youtube-dl branch December 7, 2020 16:57
@Ma27
Copy link
Member

Ma27 commented Dec 10, 2020

Why was this not backported?

@AndersonTorres
Copy link
Member

Why to backport this if there is a newer version?

@Ma27
Copy link
Member

Ma27 commented Dec 11, 2020

Well, the change didn't apply and I backported both of them. Also, the new version wasn't out back when this was merged, so I don't understand why that's a reason.

@AndersonTorres
Copy link
Member

Just because someone forgot it

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@Enzime Enzime Awaiting requested review from Enzime

@fpletz fpletz Awaiting requested review from fpletz

@Phreedom Phreedom Awaiting requested review from Phreedom

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Luflosi @Ma27 @AndersonTorres @erictapen