imhex: init at 1.6.0-git #106576
Closed
imhex: init at 1.6.0-git #106576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphorien
reviewed
Dec 10, 2020
| nativeBuildInputs = [ cmake pkgconfig ]; | ||
| buildInputs = [ nlohmann_json capstone file glfw3 glm jsoncpp llvm_9 openssl python38 ]; | ||
|
|
||
| patches = [ ./default-db.patch ]; |
There was a problem hiding this comment.
please submit the patch upstream, and fetch the corresponding commit (in your fork) with fetchpatch.
|
This patch shouldn't be upstreamed. I've talked to the developer about this
and not using the default magic database was intended to make it easier to
package on Windows.
…On Thu, Dec 10, 2020, 3:42 PM Guillaume Girol ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/editors/imhex/default.nix
<#106576 (comment)>:
> + version = "1.6.0-git"; # adds install target
+
+ src = fetchFromGitHub {
+ owner = "WerWolv";
+ repo = "ImHex";
+ #rev = "v${version}";
+ rev = "e3b5a55eba51aaab1473abf4c2a40975ddd1e9fa";
+ sha256 = "1nfq2yy21chldkg79r9nnb8n7g9fma6c9fnfy7yqgsl6y7iffxqw";
+ };
+
+ hardeningDisable = [ "format" ];
+
+ nativeBuildInputs = [ cmake pkgconfig ];
+ buildInputs = [ nlohmann_json capstone file glfw3 glm jsoncpp llvm_9 openssl python38 ];
+
+ patches = [ ./default-db.patch ];
please submit the patch upstream, and fetch the corresponding commit (in
your fork) with fetchpatch.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#106576 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7X32LQADQKNOCZWF43VWDSUEXCPANCNFSM4UVKOVVA>
.
|
|
then it should be commented copiously. |
SuperSandro2000
requested changes
Jan 18, 2021
|
|
||
| hardeningDisable = [ "format" ]; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ cmake pkgconfig ]; | |
| nativeBuildInputs = [ cmake pkg-config ]; |
Comment on lines
+1
to
+2
| { stdenv, gcc10Stdenv, cmake, pkgconfig, nlohmann_json, capstone, file, glfw3, glm, jsoncpp, llvm_9, openssl, python38, fetchFromGitHub }: | ||
| gcc10Stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| { stdenv, gcc10Stdenv, cmake, pkgconfig, nlohmann_json, capstone, file, glfw3, glm, jsoncpp, llvm_9, openssl, python38, fetchFromGitHub }: | |
| gcc10Stdenv.mkDerivation rec { | |
| { stdenv, cmake, pkg-config, nlohmann_json, capstone, file, glfw3, glm, jsoncpp, llvm_9, openssl, python3, fetchFromGitHub }: | |
| stdenv.mkDerivation rec { |
| substituteInPlace source/lang/preprocessor.cpp --replace 'include/' "${patterns}/includes/" | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
|
Also please change the version to 1.6.0 |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Another attempt has been made at #184488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ImHex has been receiving a lot of attention the past few days, I know the author, and I wanted to try it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)