Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bomi: remove #106564

Merged
merged 1 commit into from Dec 10, 2020
Merged

bomi: remove #106564

merged 1 commit into from Dec 10, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 10, 2020 •
edited by jonringer

Motivation for this change

Last release in 2015: https://github.com/xylosper/bomi/tags

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Dec 10, 2020
Merged
10 tasks
drewrisinger
drewrisinger approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
1 package removed:
bomi (†0.9.11)

Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/106564

@drewrisinger
Copy link
Contributor

FWIW, #106495 is in a similar vein.

@Mic92 Mic92 merged commit f8e50c3 into NixOS:master Dec 10, 2020
@Mic92 Mic92 deleted the bomi branch December 10, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @drewrisinger