Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kakounePlugins.quickscope-kak: init at 1.0.0 #106548

Merged
merged 1 commit into from Jan 14, 2021

Conversation

eraserhd
Copy link
Contributor

Motivation for this change

New Kakoune plugin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eraserhd
Copy link
Contributor Author

@AndersonTorres can you merge this one?

@AndersonTorres
Copy link
Member

I am running the tests.

@AndersonTorres
Copy link
Member

No outputs?

Result of nixpkgs-review pr 106548 1

@eraserhd
Copy link
Contributor Author

@AndersonTorres I'm not sure how nixpkgs-review works, but maybe it's not catching this because it needs to be configured as a Kakoune plugin. I'm using my fork of nixpkgs with this in my config: https://github.com/eraserhd/dotfiles/blob/develop/kakoune/default.nix#L21

I know I can't build from master without commenting out quicksope-kak, and I'm definitely using it regularly...

nix-build . -A kakounePlugins.quickscope-kak also works for me.

jfelice@C02CW0J5ML87 nixpkgs (dogfood)
$ nix-build . -A kakounePlugins.quickscope-kak
/nix/store/d220k3fnbf0iwwdawc55980mkdy2zs81-quickscope-kak-1.0.0

jfelice@C02CW0J5ML87 nixpkgs (dogfood)
$ find -L result
result
result/share
result/share/kak
result/share/kak/autoload
result/share/kak/autoload/plugins
result/share/kak/autoload/plugins/quickscope.lua
result/share/kak/autoload/plugins/quickscope.kak
result/share/kak/autoload/plugins/quickscope.asciidoc

@AndersonTorres
Copy link
Member

So it is OK to me.

@AndersonTorres AndersonTorres merged commit 956afcd into NixOS:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants