Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-commenter: add darwin platform #106556

Merged
merged 1 commit into from Dec 11, 2020
Merged

github-commenter: add darwin platform #106556

merged 1 commit into from Dec 11, 2020

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Dec 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Dec 10, 2020
@ofborg ofborg bot requested a review from mmahut December 10, 2020 14:00
prusnak
prusnak requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest is 0.8.0. Do you want to try to update the package?

The new version uses Go modules, so you should use buildGoModule instead of buildGoPackage. Would you like to try that? There are plenty of examples in nixpkgs tree if you grep for buildGoModule.

pkgs/development/tools/github-commenter/default.nix Outdated Show resolved Hide resolved
@onsails onsails requested a review from prusnak December 10, 2020 16:58
@ofborg ofborg bot requested a review from kalbasit December 10, 2020 17:04
prusnak
prusnak requested changes Dec 10, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message should read github-commenter: 0.5.0 -> 0.8.0 according to contributing policy

otherwise nice

@onsails onsails requested a review from prusnak December 10, 2020 17:16
@onsails onsails requested a review from prusnak December 10, 2020 17:33
@onsails
github-commenter: 0.5.0 -> 0.8.0
e02a8cf 
migrate to buildGoModule, set platforms to unix
@onsails onsails requested a review from prusnak December 10, 2020 17:39
@mmahut mmahut merged commit 36b6b3a into NixOS:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onsails @prusnak @mmahut