Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: fix CVE-2020-28916 #105591

Merged
merged 1 commit into from Dec 2, 2020
Merged

qemu: fix CVE-2020-28916 #105591

merged 1 commit into from Dec 2, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 1, 2020

Motivation for this change

While receiving packets via e1000e_write_packet_to_guest an infinite
loop could be triggered if the receive descriptor had a NULL buffer
address.

A privileged guest user could use this to induce a DoS Scenario.

Fixes: CVE-2020-28916

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
qemu: fix CVE-2020-28916
c3f2680 
While receiving packets via e1000e_write_packet_to_guest an infinite
loop could be triggered if the receive descriptor had a NULL buffer
address.

A privileged guest user could use this to induce a DoS Scenario.

Fixes: CVE-2020-28916
@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 1, 2020
@ofborg ofborg bot requested a review from edolstra December 1, 2020 16:31
@Ma27 Ma27 merged commit ccb3f1c into NixOS:master Dec 2, 2020
@Ma27
Copy link
Member

Ma27 commented Dec 2, 2020

Already taking care of the backport :)

@Ma27
Copy link
Member

Ma27 commented Dec 2, 2020

Thanks! Ported to stable as 9225644.

@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 3, 2020
@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @Ma27