_1password-gui: 0.9.5-2 -> 0.9.6 #105589

r-ryantm · 2020-12-01T15:26:08Z

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for _1password-gui is: "Multi-platform password manager"

meta.homepage for _1password-gui is: "https://1password.com/"

meta.changelog for _1password-gui is: ""

Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 0.9.6 with grep in /nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6
directory tree listing: https://gist.github.com/3c3f4e78b8c8fe5a34e8f142241e4d74
du listing: https://gist.github.com/21094b72e7beb6ac6b8662429da3475a

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
_1password-gui

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A _1password-gui https://github.com/r-ryantm/nixpkgs/archive/feeab74350c3e06e0cd25b856e96dc27aa2338d3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6
ls -la /nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:

_1password-gui

Maintainer pings

cc @danieldk @timstott for testing.

evanjs · 2020-12-01T15:32:43Z

Uh oh.
Am I doing this right?

A JavaScript error occurred in the main process
Uncaught Exception:
Error: The module '/nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6/share/1password/resources/app.asar.unpacked/index.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 85. This version of Node.js requires
NODE_MODULE_VERSION 80. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1034:18)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6/share/1password/resources/app.asar/main.js:2:206308)
    at i (/nix/store/v8piyfgrzvvalqhyzn19ib4yc9zf7mkb-1password-0.9.6/share/1password/resources/app.asar/main.js:2:110)

@danieldk @timstott

evanjs · 2020-12-01T15:36:30Z

And with electron_10 instead of electron_9:

A JavaScript error occurred in the main process
Uncaught Exception:
Error: The module '/nix/store/b2yhs1ahzn72gpcbhjd93wxgk790cy39-1password-0.9.6/share/1password/resources/app.asar.unpacked/index.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 85. This version of Node.js requires
NODE_MODULE_VERSION 82. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1196:18)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:981:32)
    at Module._load (internal/modules/cjs/loader.js:881:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:1023:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/nix/store/b2yhs1ahzn72gpcbhjd93wxgk790cy39-1password-0.9.6/share/1password/resources/app.asar/main.js:2:206308)
    at i (/nix/store/b2yhs1ahzn72gpcbhjd93wxgk790cy39-1password-0.9.6/share/1password/resources/app.asar/main.js:2:110)

evanjs · 2020-12-01T15:41:27Z

Derp. Pardon the noise, did not realize 11 is in tree, as my system hasn't been updated in a bit, and I was checking the version with nix edit, etc. 🤪

diff --git a/pkgs/tools/security/1password-gui/default.nix b/pkgs/tools/security/1password-gui/default.nix
index 620e71f23a0..32963275393 100644
--- a/pkgs/tools/security/1password-gui/default.nix
+++ b/pkgs/tools/security/1password-gui/default.nix
@@ -2,12 +2,12 @@
 , fetchurl
 , appimageTools
 , makeWrapper
-, electron_9
+, electron_11
 , openssl
 }:
 
 let
-  electron = electron_9;
+  electron = electron_11;
 
 in

Works fine with electron_11

SuperSandro2000 · 2020-12-01T16:06:59Z

@evanjs added the electron 11 update

evanjs · 2020-12-01T16:12:55Z

Works fine now that it's on Electron 11.
Some minor things with xdg interop but I don't think that's a blocker at the moment:

/run/current-system/sw/bin/xdg-open: line 883: x-www-browser: command not found

SuperSandro2000 · 2020-12-01T16:56:19Z

Works fine now that it's on Electron 11.
Some minor things with xdg interop but I don't think that's a blocker at the moment:
/run/current-system/sw/bin/xdg-open: line 883: x-www-browser: command not found

Can you do a separate PR with that?

SuperSandro2000 · 2020-12-01T16:57:58Z

Result of nixpkgs-review pr 105589 run on x86_64-darwin 1

SuperSandro2000 · 2020-12-01T16:59:22Z

Result of nixpkgs-review pr 105589 run on x86_64-linux 1

1 package built:

_1password-gui

danieldk · 2020-12-01T16:59:53Z

LGTM

evanjs · 2020-12-01T17:18:47Z

Works fine now that it's on Electron 11.
Some minor things with xdg interop but I don't think that's a blocker at the moment:
/run/current-system/sw/bin/xdg-open: line 883: x-www-browser: command not found
Can you do a separate PR with that?

Just tried it again and it opened the settings.json in Firefox so it might be fine.
Here is a similar situation and details on why it might happen.

I'm currently using xmonad+none and have most of these settings unset, so I will probably see this type of "error" more than others, but I don't think it requires any further action, unless I'm misunderstanding anything.

ofborg bot requested a review from danieldk December 1, 2020 16:03

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 1, 2020

_1password-gui: 0.9.5-2 -> 0.9.6

934f621

SuperSandro2000 force-pushed the auto-update/1password branch from feeab74 to 934f621 Compare December 1, 2020 16:07

evanjs approved these changes Dec 1, 2020

View reviewed changes

SuperSandro2000 merged commit 0cc3500 into NixOS:master Dec 1, 2020

r-ryantm deleted the auto-update/1password branch December 3, 2020 13:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

_1password-gui: 0.9.5-2 -> 0.9.6 #105589

_1password-gui: 0.9.5-2 -> 0.9.6 #105589

r-ryantm commented Dec 1, 2020

evanjs commented Dec 1, 2020 •

edited

evanjs commented Dec 1, 2020 •

edited

evanjs commented Dec 1, 2020 •

edited

SuperSandro2000 commented Dec 1, 2020

evanjs commented Dec 1, 2020 •

edited

SuperSandro2000 commented Dec 1, 2020

SuperSandro2000 commented Dec 1, 2020

SuperSandro2000 commented Dec 1, 2020

danieldk commented Dec 1, 2020

evanjs commented Dec 1, 2020

_1password-gui: 0.9.5-2 -> 0.9.6 #105589

_1password-gui: 0.9.5-2 -> 0.9.6 #105589

Conversation

r-ryantm commented Dec 1, 2020

Updates performed

To inspect upstream changes

Impact

Pre-merge build results

Maintainer pings

evanjs commented Dec 1, 2020 • edited

evanjs commented Dec 1, 2020 • edited

evanjs commented Dec 1, 2020 • edited

SuperSandro2000 commented Dec 1, 2020

evanjs commented Dec 1, 2020 • edited

SuperSandro2000 commented Dec 1, 2020

SuperSandro2000 commented Dec 1, 2020

SuperSandro2000 commented Dec 1, 2020

danieldk commented Dec 1, 2020

evanjs commented Dec 1, 2020

evanjs commented Dec 1, 2020 •

edited

evanjs commented Dec 1, 2020 •

edited

evanjs commented Dec 1, 2020 •

edited

evanjs commented Dec 1, 2020 •

edited