Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyosf: init at 1.0.5 #105618

Merged
merged 1 commit into from Dec 2, 2020
Merged

python3Packages.pyosf: init at 1.0.5 #105618

merged 1 commit into from Dec 2, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions :)

pkgs/development/python-modules/pyosf/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyosf/default.nix Outdated Show resolved Hide resolved
@bcdarwin
Copy link
Member Author

bcdarwin commented Dec 2, 2020

@IvarWithoutBones - resolved, thanks.

@bcdarwin
Copy link
Member Author

bcdarwin commented Dec 2, 2020

@GrahamcOfBorg build python37Packages.pyosf python38Packages.pyosf

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105618 run on x86_64-linux 1

3 packages built:
  • python37Packages.pyosf
  • python38Packages.pyosf
  • python39Packages.pyosf

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105618 run on x86_64-linux 1

3 packages built:
  • python37Packages.pyosf
  • python38Packages.pyosf
  • python39Packages.pyosf

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105618 run on x86_64-darwin 1

3 packages built:
  • python37Packages.pyosf
  • python38Packages.pyosf
  • python39Packages.pyosf

@SuperSandro2000 SuperSandro2000 merged commit a727aac into NixOS:master Dec 2, 2020
@bcdarwin bcdarwin deleted the pyosf branch December 2, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @SuperSandro2000 @IvarWithoutBones