inboxer: remove #105613
Merged
inboxer: remove #105613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as discussed in NixOS#104183 inboxer shall be removed. Closes NixOS#104183
ajs124
reviewed
Dec 1, 2020
pkgs/top-level/all-packages.nix
Outdated
| @@ -4779,7 +4779,7 @@ in | |||
|
|
|||
| inadyn = callPackage ../tools/networking/inadyn { }; | |||
|
|
|||
| inboxer = callPackage ../applications/networking/mailreaders/inboxer { }; | |||
| inboxer = throw ''inboxer has been removed as it is no longer maintained and no longer works as Google shut down the inbox service this package wrapped.'' | |||
There was a problem hiding this comment.
Missing ; and this should go into aliases.nix, not all-packages.nix.
There was a problem hiding this comment.
and please use double quotes as one character.
10 tasks
as suggested by @SuperSandro2000 Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
wamserma
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
as discussed in #104183 inboxer shall be removed.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)