Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dasel: 1.6.2 -> 1.8.0 #105596

Merged
merged 1 commit into from Dec 1, 2020
Merged

dasel: 1.6.2 -> 1.8.0 #105596

merged 1 commit into from Dec 1, 2020

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Dec 1, 2020

Motivation for this change

Upgrade to 1.8.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit December 1, 2020 16:54
SuperSandro2000
SuperSandro2000 requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the hash of the download.

@0x4A6F
Copy link
Member Author

0x4A6F commented Dec 1, 2020

Done.

@ryantm ryantm merged commit 16bf927 into NixOS:master Dec 1, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105596 run on x86_64-darwin 1

1 package built:
  • dasel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x4A6F @SuperSandro2000 @ryantm