Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TextFormat: 0.61 -> 0.62 #105598

Merged
merged 1 commit into from Dec 1, 2020
Merged

perlPackages.TextFormat: 0.61 -> 0.62 #105598

merged 1 commit into from Dec 1, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 1, 2020

Motivation for this change

Routine update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 1, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix
src = fetchurl {
url = "mirror://cpan/authors/id/S/SH/SHLOMIF/Text-Format-0.61.tar.gz";
sha256 = "bb8a3b8ff515c85101baf553a769337f944a05cde81f111ae78aff416bf4ae2b";
url = "mirror://cpan/authors/id/S/SH/SHLOMIF/Text-Format-0.62.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add rec to buildPerlModule we could replace the version with a varible.

@stigtsp
Copy link
Member

stigtsp commented Dec 1, 2020

@GrahamcOfBorg build perlPackages.TextFormat

stigtsp
stigtsp approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit d4b4ebd into NixOS:master Dec 1, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105598 run on x86_64-darwin 1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105598 run on x86_64-linux 1

5 packages built:
  • conglomerate
  • minc_tools
  • minc_widgets
  • perl530Packages.TextFormat
  • perl532Packages.TextFormat

@bcdarwin bcdarwin deleted the update-perl-text-format branch December 1, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @stigtsp @SuperSandro2000