Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_14: 1.14.12 -> 1.14.13, go_1_15: 1.15.5 -> 1.15.6 #105626

Merged
merged 3 commits into from Dec 4, 2020
Merged

go_1_14: 1.14.12 -> 1.14.13, go_1_15: 1.15.5 -> 1.15.6 #105626

merged 3 commits into from Dec 4, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 1, 2020

Remove tests, they are disabled by upstream.

golang/go@182bdbb

The 1.4 tests aren't necessarily supposed to pass.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @NixOS/golang

@ofborg ofborg bot requested a review from cstrahan December 1, 2020 23:10
mdlayher
mdlayher approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq zowoq marked this pull request as draft December 3, 2020 22:01
@zowoq
go_bootstrap: 1.4-bootstrap-20161024 -> 1.4-bootstrap-bdd4b95
b40accd 
Remove tests, they are disabled by upstream.

golang/go@182bdbb

> The 1.4 tests aren't necessarily supposed to pass.
@zowoq
go_1_14: 1.14.12 -> 1.14.13
9918ae4
@zowoq
go_1_15: 1.15.5 -> 1.15.6
252c090
@zowoq zowoq changed the base branch from staging to master December 3, 2020 22:09
@zowoq zowoq changed the title go_bootstrap: 1.4-bootstrap-20161024 -> 1.4-bootstrap-bdd4b95 go_1_14: 1.14.12 -> 1.14.13, go_1_15: 1.15.5 -> 1.15.6 Dec 3, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Dec 3, 2020

Added go version bumps and rebased onto master.

@zowoq zowoq marked this pull request as ready for review December 3, 2020 22:11
mdlayher
mdlayher approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM.

@zowoq zowoq merged commit 14a7df6 into NixOS:master Dec 4, 2020
@zowoq zowoq deleted the gobootstrap branch December 4, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlayher mdlayher mdlayher approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@Frostman Frostman Awaiting requested review from Frostman

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @kalbasit @mdlayher