Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.11.29 -> 2020.12.02 #105628

Merged
merged 1 commit into from Dec 2, 2020
Merged

youtube-dl: 2020.11.29 -> 2020.12.02 #105628

merged 1 commit into from Dec 2, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 1, 2020

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.12.02

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 1, 2020
@mweinelt
Copy link
Member

mweinelt commented Dec 2, 2020

Result of nixpkgs-review pr 105628 run on x86_64-linux 1

1 package failed to build:
  • bomi
35 packages built:
  • catt
  • celluloid
  • curseradio
  • haskellPackages.cut-the-crap
  • jellyfin-mpv-shim
  • jftui
  • kodi-cli
  • lollypop
  • minitube
  • mkchromecast
  • mopidy-youtube
  • mpc-qt
  • mps-youtube
  • mpv
  • persepolis
  • plex-media-player
  • plex-mpv-shim
  • python37Packages.mpv
  • python37Packages.pafy
  • python37Packages.youtube-dl
  • python37Packages.youtube-dl-light
  • python38Packages.mpv
  • python38Packages.pafy
  • youtube-dl (python38Packages.youtube-dl)
  • youtube-dl-light (python38Packages.youtube-dl-light)
  • python39Packages.mpv
  • python39Packages.pafy
  • python39Packages.youtube-dl
  • python39Packages.youtube-dl-light
  • qimgv
  • somafm-cli
  • sublime-music
  • tartube
  • tuijam
  • ytcc

mweinelt
mweinelt approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bomi failure is not a regression.

@mweinelt mweinelt merged commit 66b9609 into NixOS:master Dec 2, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Dec 2, 2020

20.09: eef919e

@zowoq zowoq added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 2, 2020
@zowoq zowoq deleted the ytdl branch December 2, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@Enzime Enzime Awaiting requested review from Enzime

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@fpletz fpletz Awaiting requested review from fpletz

@Ma27 Ma27 Awaiting requested review from Ma27

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @mweinelt