weechatScripts.colorize_nicks: init at 27 #105633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,30 @@ | |||
| { stdenv, lib, fetchurl }: | |||
There was a problem hiding this comment.
lib can be replaced with stdenv.lib.
There was a problem hiding this comment.
I don't feel like indirections like this are the way to go.
There was a problem hiding this comment.
Suggested change
| { stdenv, lib, fetchurl }: | |
| { pkgs }: |
Then we can use pkgs.stdenv, pkgs.lib, pkgs.fetchurl?
</kidding>
More to the point. Do we have any guidelines as to what to prefer here? I think I prefer the solution present in the PR.
pkgs/applications/networking/irc/weechat/scripts/colorize_nicks/default.nix
Show resolved
Hide resolved
pkgs/applications/networking/irc/weechat/scripts/colorize_nicks/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/irc/weechat/scripts/colorize_nicks/default.nix
Outdated
Show resolved
Hide resolved
|
Result of 1 package marked as broken and skipped:
|
alyssais
force-pushed
the
colorize_nicks
branch
from
363e369
to
932d2f1
Compare
|
I couldn’t reproduce the evaluation error. |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
mweinelt
reviewed
Dec 9, 2020
| meta = with lib; { | ||
| inherit (weechat.meta) platforms; | ||
| description = "Use the weechat nick colors in the chat area"; | ||
| licenses = licenses.gpl2Plus; |
There was a problem hiding this comment.
Suggested change
| licenses = licenses.gpl2Plus; | |
| license = licenses.gpl2Plus; |
alyssais
force-pushed
the
colorize_nicks
branch
from
932d2f1
to
87ee41b
Compare
|
Result of 1 package built:
|
mweinelt
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)