Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: 19.03.13 -> 19.03.14 #105653

Merged
merged 1 commit into from Dec 2, 2020
Merged

docker: 19.03.13 -> 19.03.14 #105653

merged 1 commit into from Dec 2, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Dec 2, 2020 •
edited

Motivation for this change

https://github.com/docker/docker-ce/releases/tag/v19.03.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@srhb
Copy link
Contributor

srhb commented Dec 2, 2020

Result of nixpkgs-review pr 105653 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
12 packages built:
  • charliecloud
  • disnix
  • disnixos
  • docker (docker-edge ,docker_19_03)
  • docker-gc
  • dydisnix
  • dysnomia
  • out-of-tree
  • pipework
  • python37Packages.jupyter-repo2docker
  • python38Packages.jupyter-repo2docker
  • python39Packages.jupyter-repo2docker

@jonringer
Copy link
Contributor

@GrahamcOfBorg test docker

jonringer
jonringer approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/105653
1 package blacklisted:
tests.nixos-functions.nixos-test

12 packages built:
charliecloud disnix disnixos docker docker-gc dydisnix dysnomia out-of-tree pipework python37Packages.jupyter-repo2docker python38Packages.jupyter-repo2docker python39Packages.jupyter-repo2docker

@jonringer jonringer merged commit b999879 into NixOS:master Dec 2, 2020
@Frostman Frostman deleted the docker-19.03.14 branch December 2, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@jonringer jonringer jonringer approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@periklis periklis Awaiting requested review from periklis

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@tailhook tailhook Awaiting requested review from tailhook

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @srhb @jonringer