Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation updates from Docbook to CommonMark #105648

Merged
merged 2 commits into from Dec 5, 2020
Merged

Documentation updates from Docbook to CommonMark #105648

merged 2 commits into from Dec 5, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Dec 2, 2020 •
edited

Motivation for this change

OCaml
#104968

Shell-helpers
#105261

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres
Copy link
Member Author

Yes, I am pulling various at once.

This was referenced Dec 2, 2020
Closed
Closed
ryantm
ryantm requested changes Dec 3, 2020
View reviewed changes
doc/builders/packages/shell-helpers.section.md Outdated Show resolved Hide resolved
doc/languages-frameworks/ocaml.section.md Outdated Show resolved Hide resolved
This was linked to issues Dec 3, 2020
Convert Ocaml from Docbook to Commonmark #104968
Closed
Convert Shell-Helpers from Docbook to CommonMark #105261
Closed
ryantm
ryantm requested changes Dec 3, 2020
View reviewed changes
doc/languages-frameworks/ocaml.section.md Outdated Show resolved Hide resolved
ryantm
ryantm approved these changes Dec 5, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and rendering looks good!

@ryantm ryantm merged commit 25e00d8 into NixOS:master Dec 5, 2020
@ryantm
Copy link
Member

ryantm commented Dec 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Shell-Helpers from Docbook to CommonMark Convert Ocaml from Docbook to Commonmark
2 participants
@AndersonTorres @ryantm