Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.llfuse: 1.3.6 -> 1.3.8-2020-12-04 #106337

Closed
wants to merge 1 commit into from
Closed

python3Packages.llfuse: 1.3.6 -> 1.3.8-2020-12-04 #106337

wants to merge 1 commit into from

Conversation

siriobalmelli
Copy link
Contributor

Newer versions of pytest break llfuse.
This was fixed upstream in allure-framework/allure-python#381
but is not released yet.

Update llfuse to upstream rather than downgrading pytest dependency.

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

I utilize downstream packages that depend on llfuse.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli
python3Packages.llfuse: 1.3.6 -> 1.3.8-2020-12-04
9872837 
Newer versions of pytest break llfuse.
This was fixed upstream in allure-framework/allure-python#381
but is not released yet.

Update llfuse to upstream rather than downgrading pytest dependency.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@ofborg ofborg bot requested a review from bjornfor December 8, 2020 09:19
@bachp bachp mentioned this pull request Dec 8, 2020
Closed
@bachp
Copy link
Member

bachp commented Dec 8, 2020

@siriobalmelli Thanks, but there is already a PR addressing the same issue: #106279

@siriobalmelli
Copy link
Contributor Author

@bachp sorry, I missed that one while I was working on this one.

#106279 seems cleaner: instead of building from source it's patching only the test issue. Closing this.

@siriobalmelli siriobalmelli deleted the fix/llfuse branch December 9, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siriobalmelli @bachp