haskellPackages.cryptohash-sha512: fix by jailbreaking #106333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdepillabout
reviewed
Dec 8, 2020
layus
force-pushed
the
haskell-cryptohash-sha512
branch
from
c2e4ca6
to
e6e2ce6
Compare
ofborg
bot
added
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 501+
10.rebuild-linux: 2501-5000
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-linux: 1
10.rebuild-linux: 1-10
10.rebuild-darwin: 501+
10.rebuild-darwin: 2501-5000
10.rebuild-linux: 501+
10.rebuild-linux: 2501-5000
labels
cdepillabout
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Thanks for fixing this up, this LGTM! haskell-packages.nix should be updated in about 24 hours, and this package will be unmarked broken. The haskell-packages branch should get merged into master in a week or so.
We could add a version check because the jailbreak can be removed when the package gets updated. If this one gets a new version it will certainly include the fix. Not sure how to make that in a maintainable way.
We've tried to do this in the past, but it ended up being more trouble than it is worth :-\
We are always looking for suggestions of how we can improve here, or even just more people to help review nixpkgs issue with the haskell label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix cryptohash-sha512.
It has a long pending PR for update to newer GHC, and has been tested to work with more recent GHC. This package is intended to be used by HNix.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"/cc @peti