Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #106321

Merged
merged 102 commits into from Dec 11, 2020
Merged

Staging next #106321

merged 102 commits into from Dec 11, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 8, 2020

Motivation for this change

https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

DavHau and others added 30 commits October 20, 2020 19:09
Co-authored-by: symphorien <symphorien@users.noreply.github.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Often packages install the compiled files to
`$(libdir)/guile/$(GUILE_EFFECTIVE_VERSION)/ccache` (e.g. see
guile-opengl). This path is not explicitly given in the info page, but
is used in a couple of places, and is also part of `%load-compiled-path`
variable in guile (for `"${guile}/lib/guile/2.2/ccache`).

Similarly, the site-ccache is also part of `%load-compiled-path` in
guile.
It's broken under Python 3, ironically due to the patch we're carrying.
Fix it, and add a test to check it works.

Fixes #93230.
This doesn't do anything. Building with includeEmail = true produces
the same set as includeEmail = false, and the substitute rule removes
a random dictionary index operation.
Guile setup hook, use compiled files
autoPatchelfHook: optimize performance; better error handling
@FRidh
Copy link
Member Author

FRidh commented Dec 9, 2020

tracker blocks https://hydra.nixos.org/build/132356591
cc @NixOS/gnome

@jtojnar
Copy link
Contributor

jtojnar commented Dec 9, 2020

Possibly just a flaky builder?

@TredwellGit
Copy link
Member

Possibly just a flaky builder?

Nope, I can't build it either.

@TredwellGit
Copy link
Member


Set doCheck = false; and it builds.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 9, 2020

Looks like it is incompatibility with sqlite 3.34.0: https://bugs.archlinux.org/task/68903

@jonringer
Copy link
Contributor

the error message is a bit odd:

Bail out! Tracker-FATAL-CRITICAL: SQLite error: database disk image is malformed (errno: Success)

It failed.... successfully?

@FRidh
Copy link
Member Author

FRidh commented Dec 10, 2020

@jtojnar
Copy link
Contributor

jtojnar commented Dec 10, 2020

Added a patch for the tracker issue.

@FRidh
Copy link
Member Author

FRidh commented Dec 10, 2020

tracker now seems to have an error during installation phase https://hydra.nixos.org/build/132506698. Wrong target directory?

Traceback (most recent call last):
  File "/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/lib/python3.8/site-packages/mesonbuild/mesonmain.py", line 140, in run
    return options.run_func(options)
  File "/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 554, in run
    installer.do_install(datafilename)
  File "/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 375, in do_install
    self.install_data(d)
  File "/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 406, in install_data
    if self.do_copyfile(fullfilename, outfilename, makedirs=(d.dirmaker, outdir)):
  File "/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 266, in do_copyfile
    dirmaker.makedirs(outdir, exist_ok=True)
  File "/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/lib/python3.8/site-packages/mesonbuild/minstall.py", line 63, in makedirs
    os.makedirs(path, exist_ok=exist_ok)
  File "/nix/store/jdp800qwb3v330ggl6iq722ww96q2444-python3-3.8.6/lib/python3.8/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/nix/store/jdp800qwb3v330ggl6iq722ww96q2444-python3-3.8.6/lib/python3.8/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/nix/store/jdp800qwb3v330ggl6iq722ww96q2444-python3-3.8.6/lib/python3.8/os.py", line 213, in makedirs
    makedirs(head, exist_ok=exist_ok)
  File "/nix/store/jdp800qwb3v330ggl6iq722ww96q2444-python3-3.8.6/lib/python3.8/os.py", line 223, in makedirs
    mkdir(name, mode)
PermissionError: [Errno 13] Permission denied: '/usr'
FAILED: meson-install 
/nix/store/n9vj7i7armczjs1x7qzyqhfhzfidrv62-meson-0.56.0/bin/meson install --no-rebuild
ninja: build stopped: subcommand failed.

@TredwellGit
Copy link
Member

It builds for me on staging.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 10, 2020

Did we merge the systemd pkg-config fix yet? Edit: Does not look like it is the case 74f96a5

github-actions bot and others added 4 commits December 11, 2020 00:40
@FRidh FRidh merged commit 3b85d7d into master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet